From: Nick Piggin <npiggin@gmail.com>
To: "J. R. Okajima" <hooanon05@yahoo.co.jp>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: vfs-scale, nd->inode after __do_follow_link()
Date: Fri, 14 Jan 2011 15:09:10 +1100 [thread overview]
Message-ID: <AANLkTinXPOSxHPtffqe3m5MWppDfr6kFVMsd6k7-dkic@mail.gmail.com> (raw)
In-Reply-To: <7352.1294971049@jrobl>
On Fri, Jan 14, 2011 at 1:10 PM, J. R. Okajima <hooanon05@yahoo.co.jp> wrote:
>
> Isn't it path.dentry->d_inode instead of nd.inode?
>
> J. R. Okajima
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 5bb7588..1df3bee 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2356,8 +2374,9 @@ reval:
> goto exit_dput;
> error = __do_follow_link(&path, &nd, &cookie);
> if (unlikely(error)) {
> - if (!IS_ERR(cookie) && nd.inode->i_op->put_link)
> - nd.inode->i_op->put_link(path.dentry, &nd, cookie);
> + struct dentry *i = path.dentry->d_inode;
> + if (!IS_ERR(cookie) && i->i_op->put_link)
> + i->i_op->put_link(path.dentry, &nd, cookie);
> /* nd.path had been dropped */
> nd.path = path;
> goto out_path;
It should be the inode we followed, rather than the inode of the
new path, I think.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-14 4:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 2:10 vfs-scale, nd->inode after __do_follow_link() J. R. Okajima
2011-01-14 2:33 ` J. R. Okajima
2011-01-14 4:09 ` Nick Piggin [this message]
2011-01-14 4:41 ` J. R. Okajima
2011-01-14 5:28 ` Al Viro
2011-01-14 5:38 ` J. R. Okajima
2011-01-14 5:40 ` J. R. Okajima
2011-01-14 8:40 ` Nick Piggin
2011-01-14 9:17 ` Sedat Dilek
2011-01-14 23:34 ` J.H.
2011-01-14 12:54 ` J. R. Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinXPOSxHPtffqe3m5MWppDfr6kFVMsd6k7-dkic@mail.gmail.com \
--to=npiggin@gmail.com \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).