From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Nick Piggin <npiggin@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
shaohua.li@intel.com, alex.shi@intel.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] vfs: Fix RCU path walk failiures due to uninitialized nameidata seq number for root directory
Date: Fri, 15 Apr 2011 14:54:23 -0700 [thread overview]
Message-ID: <BANLkTi=Z4N4BmjHZkAFev85YL0a=fji4BA@mail.gmail.com> (raw)
In-Reply-To: <4DA8B3FB.5020401@linux.intel.com>
On Fri, Apr 15, 2011 at 2:09 PM, Andi Kleen <ak@linux.intel.com> wrote:
> On 4/15/2011 11:39 AM, Tim Chen wrote:
>>
>> During RCU walk in path_lookupat and path_openat, the rcu lookup
>> frequently failed because when root directory was looked up, seq number
>> was not properly set in nameidata. We dropped out of RCU walk in
>> nameidata_drop_rcu due to mismatch in directory entry's seq number. We
>> reverted to slow path walk that need to take references.
>
> Thanks Tim. Adding Andrew, Linus too. IMHO this fix is quite important to
> actually make the fabled RCU dcache work -- without it it's just slower
> because
> it will fallback nearly allways.
Well, only for absolute paths, but yes.
I think all my benchmarking was for thing like "git diff", which are
all about the relative paths and wouldn't have triggered this case.
So this patch does look correct, and yes, should also be stable material for 38.
And it's pretty fundamental. But I'd like to get a few more acks
exactly because it's so fundamental. Al and Nick sadly are both gone.
Anybody else feel like they know something about the path lookup code?
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-15 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 18:39 [PATCH] vfs: Fix RCU path walk failiures due to uninitialized nameidata seq number for root directory Tim Chen
2011-04-15 21:09 ` Andi Kleen
2011-04-15 21:54 ` Linus Torvalds [this message]
2011-04-16 5:43 ` Sedat Dilek
2011-04-16 10:27 ` Shi, Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=Z4N4BmjHZkAFev85YL0a=fji4BA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=shaohua.li@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).