From mboxrd@z Thu Jan 1 00:00:00 1970 From: richard -rw- weinberger Subject: Re: [PATCH] fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers Date: Wed, 29 Jun 2011 19:05:44 +0200 Message-ID: References: <1309275310-10987-1-git-send-email-josef@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, hch@infradead.org To: Josef Bacik Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:49723 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147Ab1F2RFp convert rfc822-to-8bit (ORCPT ); Wed, 29 Jun 2011 13:05:45 -0400 In-Reply-To: <1309275310-10987-1-git-send-email-josef@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jun 28, 2011 at 5:35 PM, Josef Bacik wrote: > Btrfs needs to be able to control how filemap_write_and_wait_range() = is called > in fsync to make it less of a painful operation, so push down taking = i_mutex and > the calling of filemap_write_and_wait() down into the ->fsync() handl= ers. =A0Some > file systems can drop taking the i_mutex altogether it seems, like ex= t3 and > ocfs2. =A0For correctness sake I just pushed everything down in all c= ases to make > sure that we keep the current behavior the same for everybody, and th= en each > individual fs maintainer can make up their mind about what to do from= there. > Thanks, > > Signed-off-by: Josef Bacik A small note from checkpatch.pl: ERROR: "foo * bar" should be "foo *bar" #1109: FILE: fs/hostfs/hostfs_kern.c:367: + struct inode * inode =3D file->f_mapping->host; --=20 Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html