* [PATCH] fix hardcoded reference to /mnt/test in common.attr
@ 2011-05-31 14:21 Amir Goldstein
2011-05-31 20:29 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Amir Goldstein @ 2011-05-31 14:21 UTC (permalink / raw)
To: XFS; +Cc: sergey ivanov, Christoph Hellwig, linux-fsdevel
From: Amir Goldstein <amir73il@users.sf.net>
When trying to run test 70, we encountered several problems.
Sergey has strace'd some of the problems to attempts to
set xattr on the wrong test dir (/mnt/test/), which appears to be
hardcoded in common.attr.
Reported-by: Sergey Ivanov <sergey57@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@users.sf.net>
---
common.attr | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common.attr b/common.attr
index 343edfc..37d0927 100644
--- a/common.attr
+++ b/common.attr
@@ -163,7 +163,7 @@ _require_attrs()
# stored on disk.
#
touch $TEST_DIR/syscalltest
- attr -s "user.xfstests" -V "attr" /mnt/test/ >
$TEST_DIR/syscalltest.out 2>&1
+ attr -s "user.xfstests" -V "attr" $TEST_DIR >
$TEST_DIR/syscalltest.out 2>&1
cat $TEST_DIR/syscalltest.out >> $here/$seq.full
if grep -q 'Function not implemented' $TEST_DIR/syscalltest.out; then
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix hardcoded reference to /mnt/test in common.attr
2011-05-31 14:21 [PATCH] fix hardcoded reference to /mnt/test in common.attr Amir Goldstein
@ 2011-05-31 20:29 ` Christoph Hellwig
2011-06-01 3:26 ` Amir Goldstein
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2011-05-31 20:29 UTC (permalink / raw)
To: Amir Goldstein; +Cc: XFS, linux-fsdevel, sergey ivanov
Thanks, applied.
(after fixing whitespace damage in the patch)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix hardcoded reference to /mnt/test in common.attr
2011-05-31 20:29 ` Christoph Hellwig
@ 2011-06-01 3:26 ` Amir Goldstein
0 siblings, 0 replies; 3+ messages in thread
From: Amir Goldstein @ 2011-06-01 3:26 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: XFS, linux-fsdevel, sergey ivanov
On Tue, May 31, 2011 at 11:29 PM, Christoph Hellwig <hch@infradead.org> wrote:
> Thanks, applied.
>
> (after fixing whitespace damage in the patch)
Sorry about those... I usually get away with copy&paste of a single patch
to gmail.
it works with kernel coding convention of tab indentation and short lines,
but xfstests appear to have some space indentations and long lines,
so it doesn't go that well.
I apologize in advance for the other damaged patch already sent out
(ext4dev FSTYP support)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-01 3:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-31 14:21 [PATCH] fix hardcoded reference to /mnt/test in common.attr Amir Goldstein
2011-05-31 20:29 ` Christoph Hellwig
2011-06-01 3:26 ` Amir Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).