From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bongani Hlope <bonganilinux@mweb.co.za>
Cc: npiggin@kernel.dk, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Greg KH <greg@kroah.com>,
"Dr. Bernd Feige" <bernd.feige@uniklinik-freiburg.de>,
Petr Vandrovec <petr@vandrovec.name>,
Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [Regression] 2.6.38 ncpfs
Date: Thu, 14 Apr 2011 10:29:34 -0700 [thread overview]
Message-ID: <BANLkTin=xwfr5aVhzyL_FFo3K3SNMW9OQw@mail.gmail.com> (raw)
In-Reply-To: <201104141914.23529.bonganilinux@mweb.co.za>
On Thu, Apr 14, 2011 at 10:14 AM, Bongani Hlope <bonganilinux@mweb.co.za> wrote:
>
> The bug is caused by commit fb2d5b86aff355a27ebfc132d3c99f4a940cc3fe, which
> was committed by Nick. Can you please either revert Nick's changes or include
> the attached patch (or a better version, because I'm not that clued up with
> ncpfs).
Hmm. Your patch isn't correct. You can't just do
if (!mutex_is_locked(&dentry->d_inode->i_mutex)) {
mutex_lock(&inode->i_mutex);
because code like that makes no sense - maybe it was locked by
somebody _else_, and you would need to lock it.
That said, I do think that the
BUG_ON(!mutex_is_locked(&dentry->d_inode->i_mutex));
is wrong, since even the comment above it talks about the _parent_
dentry, not the dentry that is actually being modified.
So there's clearly a bug somewhere, and the fix may be to just remove
that BUG_ON().
Added some more people to the cc.
Linus
next prev parent reply other threads:[~2011-04-14 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 16:58 [Regression] 2.6.38 ncpfs Bongani Hlope
2011-04-14 17:14 ` Bongani Hlope
2011-04-14 17:29 ` Linus Torvalds [this message]
2011-04-14 20:17 ` Bongani Hlope
2011-04-14 20:22 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2011-04-15 7:53 Bongani Hlope
2011-04-15 8:53 ` Dr. Bernd Feige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTin=xwfr5aVhzyL_FFo3K3SNMW9OQw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bernd.feige@uniklinik-freiburg.de \
--cc=bonganilinux@mweb.co.za \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=petr@vandrovec.name \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).