From mboxrd@z Thu Jan  1 00:00:00 1970
From: Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/5] splice: locking changes and code refactoring
Date: Fri, 17 Jan 2014 23:22:04 -0800
Message-ID: <CA+55aFw4LgyYEkygxHUnpKZg3jMACGzsyENc9a9rWFmLcaRefQ@mail.gmail.com>
References: <20131212181459.994196463@bombadil.infradead.org>
	<20140113141416.GA30117@infradead.org>
	<20140113235646.GR10323@ZenIV.linux.org.uk>
	<20140114132207.GA25170@infradead.org>
	<20140114172033.GU10323@ZenIV.linux.org.uk>
	<20140118064040.GE10323@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>, Mark Fasheh <mfasheh@suse.com>,
	Joel Becker <jlbec@evilplan.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>, xfs@oss.sgi.com,
	Sage Weil <sage@inktank.com>, Steve French <sfrench@samba.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-vb0-f52.google.com ([209.85.212.52]:47176 "EHLO
	mail-vb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752544AbaARHWF (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 18 Jan 2014 02:22:05 -0500
Received: by mail-vb0-f52.google.com with SMTP id p14so1918621vbm.39
        for <linux-fsdevel@vger.kernel.org>; Fri, 17 Jan 2014 23:22:04 -0800 (PST)
In-Reply-To: <20140118064040.GE10323@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jan 17, 2014 at 10:40 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Objections, comments?

I certainly object to the "map, then unmap" approach. No VM games.

But if it can be done more naturally as a writev, then that may well
be ok. As long as we're talking about just the
default_file_splice_write() case, and people who want to do special
things with page movement can continue to do so..

              Linus