linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ian Kent <ikent@redhat.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	autofs mailing list <autofs@linux.kernel.org>
Subject: Re: [PATCH] autofs4 - fix get_next_positive_subdir()
Date: Tue, 22 May 2012 19:53:49 -0700	[thread overview]
Message-ID: <CA+55aFwCESHx0d+ZEe-zi3PS6mkMaMng75Dnfit93cTwhb5gSg@mail.gmail.com> (raw)
In-Reply-To: <20120523024950.3905.89811.stgit@perseus.themaw.net>

On Tue, May 22, 2012 at 7:49 PM, Ian Kent <ikent@redhat.com> wrote:
>
> The locking for the list traversal in get_next_positive_subdir() is
> wrong, so fix it.

As an explanation, this kind of thing is totally useless. It doesn't
actually give any information at all. It's like saying "change
locking"

What happened, and why? Why is the new nested spinlock ok and won't
deadlock against other nested users? Wazzup?

                 Linus

  reply	other threads:[~2012-05-23  2:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23  2:49 [PATCH] autofs4 - fix get_next_positive_subdir() Ian Kent
2012-05-23  2:53 ` Linus Torvalds [this message]
2012-05-23  6:19   ` Ian Kent
2012-05-23  7:22   ` Ian Kent
2012-05-23  7:30     ` Ian Kent
2012-05-23  9:03       ` Ian Kent
  -- strict thread matches above, loose matches on Subject: below --
2012-08-06  1:37 Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFwCESHx0d+ZEe-zi3PS6mkMaMng75Dnfit93cTwhb5gSg@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=autofs@linux.kernel.org \
    --cc=ikent@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).