From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: nfsd changes for 3.5 Date: Thu, 31 May 2012 11:58:34 -0700 Message-ID: References: <20120531182457.GB25955@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20120531182457.GB25955-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Thu, May 31, 2012 at 11:24 AM, J. Bruce Fields wrote: > > Sorry this is a bit late. =A0In fact I still have a review backlog (a= t a > minimum some bugfixes), so will send a second pull later. Quite frankly, I'm not going to pull this without lots of explanations. The VFS-level changes have no acks or sign-offs from anybody else, and quite frankly, if I understand them correctly they look f*cking disgusting. If I read them right, they break delegations of a file (which can involve long waits for clients - no?) while holding on to the directory inode lock (both directories for cross-inode renames). Which seems to be a singularly idiotic thing to do and sounds to me like a fundamental design mistake. We simply don't do these kinds of VFS changes without having discussions and acks from people, notably Al. As to "second pull later" - if you haven't reviewed the code already, it's damn well much too late in the merge window to do it now. So quite frankly, this *all* looks like 3.6 material to me, and that's assuming you can convince people that file-delegation breaking really should happen with all lookups on the directory the file is in blocked by the directory inode mutex in the first place. Or tell me I'm a moron and I misread the patches and don't know what I'm talking about. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html