From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ian Kent <ikent@redhat.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
autofs mailing list <autofs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] autofs4 - use simple_empty() for empty directory check
Date: Fri, 16 Nov 2012 07:45:29 -0800 [thread overview]
Message-ID: <CA+55aFx-9A0xknhX7z9KmLAoGMf5GXhuFgroZUixHtevGAFsOQ@mail.gmail.com> (raw)
In-Reply-To: <20121116041523.18624.46918.stgit@perseus.themaw.net>
On Thu, Nov 15, 2012 at 8:15 PM, Ian Kent <ikent@redhat.com> wrote:
>
> +static inline int __simple_empty(struct dentry *dentry)
> +{
This seems completely bogus.
It's a duplicate of the existing fs/libfs.c "simple_empty()" function,
but without taking the outer lock.
That kind of code duplication - and doing it in a totally different
file, and making it look autofs-specific - seems entirely wrong.
Linus
next prev parent reply other threads:[~2012-11-16 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 4:15 [PATCH] autofs4 - use simple_empty() for empty directory check Ian Kent
2012-11-16 15:45 ` Linus Torvalds [this message]
2012-11-16 16:36 ` Ian Kent
2012-11-16 16:43 ` Linus Torvalds
2012-11-16 17:34 ` Al Viro
2012-11-17 2:29 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFx-9A0xknhX7z9KmLAoGMf5GXhuFgroZUixHtevGAFsOQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=autofs@vger.kernel.org \
--cc=ikent@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).