linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Waiman Long <longman@redhat.com>,
	"Wangkai (Kevin,C)" <wangkai86@huawei.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"walters@verbum.org" <walters@verbum.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"Renjinyong (Renjinyong,
	Business Support Dept)" <renjinyong@huawei.com>
Subject: Re: [PATCH] fs/dcache: dentries should free after files unlinked or directories removed
Date: Mon, 4 Sep 2017 08:48:55 -0700	[thread overview]
Message-ID: <CA+55aFx1QraMTJrnOiNzfbx2dUCNszPT66m47R8QSamWNhRpWg@mail.gmail.com> (raw)
In-Reply-To: <20170904125930.GD1761@quack2.suse.cz>

On Mon, Sep 4, 2017 at 5:59 AM, Jan Kara <jack@suse.cz> wrote:
>
> The reason why I'm objecting is that the limit on the number of negative
> dentries is another tuning knob, it is for very specific cases, and most of
> sysadmins will have no clue how to set it properly (even I wouldn't have a
> good idea).

We could make some cut at just doing it without any explicit tuning.

In particular, we could probably have some fairly trivial logic to
count negative dentries vs positive ones, and start pruning negative
dentries if we've crossed some threshold and we have more of them than
of the positive kind. That's a fairly obvious "somebody is doing
something bad" measure which wouldn't need a ton of tuning.

That said, I'm not convinced it's a huge deal and worth it - I'm just
saying that I don't think it's necessarily crazy or something I'd NAK
automatically.

                  Linus

  reply	other threads:[~2017-09-04 15:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07  9:54 [PATCH] fs/dcache: dentries should free after files unlinked or directories removed Wangkai
2017-08-25  7:06 ` Wangkai (Kevin,C)
2017-08-25 14:47   ` Jan Kara
2017-08-25 15:10     ` Colin Walters
2017-08-25 16:43       ` Linus Torvalds
2017-08-26  6:56     ` Wangkai (Kevin,C)
2017-08-26 16:18       ` Linus Torvalds
2017-08-27 15:05         ` Waiman Long
2017-08-31  7:53           ` Jan Kara
2017-08-31 16:27             ` Waiman Long
2017-09-04 12:59               ` Jan Kara
2017-09-04 15:48                 ` Linus Torvalds [this message]
2017-09-04 21:45                 ` Waiman Long
2017-08-28  6:31         ` Wangkai (Kevin,C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFx1QraMTJrnOiNzfbx2dUCNszPT66m47R8QSamWNhRpWg@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=renjinyong@huawei.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=walters@verbum.org \
    --cc=wangkai86@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).