From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f65.google.com ([209.85.218.65]:33545 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbcFISpD (ORCPT ); Thu, 9 Jun 2016 14:45:03 -0400 MIME-Version: 1.0 In-Reply-To: <1465448705-25055-3-git-send-email-deepa.kernel@gmail.com> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-3-git-send-email-deepa.kernel@gmail.com> From: Linus Torvalds Date: Thu, 9 Jun 2016 11:45:01 -0700 Message-ID: Subject: Re: [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps To: Deepa Dinamani Cc: linux-fsdevel , Linux Kernel Mailing List , Arnd Bergmann , Thomas Gleixner , Al Viro , y2038@lists.linaro.org, "Theodore Ts'o" , Andreas Dilger , "linux-ext4@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani wrote: > CURRENT_TIME_SEC and CURRENT_TIME are not y2038 safe. > current_fs_time() will be transitioned to be y2038 safe > along with vfs. > > current_fs_time() returns timestamps according to the > granularities set in the super_block. All existing users and all the ones in this patch (and the others too, although I didn't go through them very carefully) really would prefer just passing in the inode directly, rather than the superblock. So I don't want to add more users of this broken interface. It was a mistake to use the superblock. The fact that the time granularity exists there is pretty much irrelevant. If every single user wants to use an inode pointer, then that is what the function should get. Linus