* [PATCH v2] exec: clarify reasoning for euid/egid reset
@ 2016-05-17 19:14 Kees Cook
2016-05-17 20:57 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2016-05-17 19:14 UTC (permalink / raw)
To: Jonathan Corbet
Cc: David Howells, Linus Torvalds, Serge Hallyn, Willy Tarreau,
linux-doc, Alexander Viro, linux-fsdevel, linux-kernel
This section of code initially looks redundant, but is required. This
improves the comment to explain more clearly why the reset is needed.
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
---
v2:
- clarified example as a setuid script, dhowells
---
fs/exec.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/exec.c b/fs/exec.c
index c4010b8207a1..a98b21d47385 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1387,7 +1387,12 @@ static void bprm_fill_uid(struct linux_binprm *bprm)
kuid_t uid;
kgid_t gid;
- /* clear any previous set[ug]id data from a previous binary */
+ /*
+ * Since this can be called multiple times (via prepare_binprm),
+ * we must clear any previous work done when setting set[ug]id
+ * bits from any earlier bprm->file uses (for example when run
+ * first for a setuid script then again for its interpreter).
+ */
bprm->cred->euid = current_euid();
bprm->cred->egid = current_egid();
--
2.6.3
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] exec: clarify reasoning for euid/egid reset
2016-05-17 19:14 [PATCH v2] exec: clarify reasoning for euid/egid reset Kees Cook
@ 2016-05-17 20:57 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2016-05-17 20:57 UTC (permalink / raw)
To: Kees Cook
Cc: Jonathan Corbet, David Howells, Serge Hallyn, Willy Tarreau,
open list:DOCUMENTATION, Alexander Viro, linux-fsdevel,
Linux Kernel Mailing List
On Tue, May 17, 2016 at 12:14 PM, Kees Cook <keescook@chromium.org> wrote:
> This section of code initially looks redundant, but is required. This
> improves the comment to explain more clearly why the reset is needed.
Applied.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-17 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-17 19:14 [PATCH v2] exec: clarify reasoning for euid/egid reset Kees Cook
2016-05-17 20:57 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).