From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH v2 00/10] evacuate struct page from the block layer, introduce __pfn_t Date: Fri, 8 May 2015 20:52:00 -0700 Message-ID: References: <20150507173641.GA21781@gmail.com> <554BA748.9030804@linux.intel.com> <20150507191107.GB22952@gmail.com> <554CBE17.4070904@redhat.com> <20150508140556.GA2185@gmail.com> <21836.51957.715473.780762@quad.stoffel.home> <554CEB5D.90209@redhat.com> <554D78C4.30607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: John Stoffel , Ingo Molnar , Dave Hansen , Dan Williams , Linux Kernel Mailing List , Boaz Harrosh , Jan Kara , Mike Snitzer , Neil Brown , Benjamin Herrenschmidt , Heiko Carstens , Chris Mason , Paul Mackerras , "H. Peter Anvin" , Christoph Hellwig , Alasdair Kergon , "linux-nvdimm@lists.01.org" , Mel Gorman , Matthew Wilcox , Ross Zwisler , Martin Schwidefsky , Jens Axboe , "Theodore Ts'o" , "Martin K. Pet To: Rik van Riel Return-path: Received: from mail-ie0-f176.google.com ([209.85.223.176]:34581 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbbEIDwB (ORCPT ); Fri, 8 May 2015 23:52:01 -0400 In-Reply-To: <554D78C4.30607@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 8, 2015 at 8:02 PM, Rik van Riel wrote: > > The TLB performance bonus of accessing the large files with > large pages may make it worthwhile to solve that hard problem. Very few people can actually measure that TLB advantage on systems with good TLB's. It's largely a myth, fed by some truly crappy TLB fill systems (particularly sw-filled TLB's on some early RISC CPU's, but even "modern" CPU's sometimes have glass jaws here because they cant' prefetch TLB entries or do concurrent page table walks etc). There are *very* few loads that actually have the kinds of access patterns where TLB accesses dominate - or are even noticeable - compared to the normal memory access costs. That is doubly true with file-backed storage. The main reason you get TLB costs to be noticeable is with very sparse access patterns, where you hit as many TLB entries as you hit pages. That simply doesn't happen with file mappings. Really. The whole thing about TLB advantages of hugepages is this almost entirely made-up stupid myth. You almost have to make up the benchmark for it (_that_ part is easy) to even see it. Linus