From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
MIME-Version: 1.0
In-Reply-To: <20160229165031.GY17997@ZenIV.linux.org.uk>
References: <20160226212137.GF17997@ZenIV.linux.org.uk>
	<CACT4Y+Z2RmFvtxdRY1=3h2sXMwmafFq+qgcZWGOoeZ79Yrwxzw@mail.gmail.com>
	<20160226220759.GH17997@ZenIV.linux.org.uk>
	<20160227222748.GI17997@ZenIV.linux.org.uk>
	<CACT4Y+beVWKoQJ8Wfo4i8ij067hQLGmdcnrfP8CU-3eECgOLFQ@mail.gmail.com>
	<CACT4Y+YztEDaepwKnzOnh=0+BN1NdpoCVOE-FLXquvKfNgndMg@mail.gmail.com>
	<20160228170133.GM17997@ZenIV.linux.org.uk>
	<20160228200100.GP17997@ZenIV.linux.org.uk>
	<20160229130924.GV17997@ZenIV.linux.org.uk>
	<CA+55aFz3qdv+sEA_mk0mVQ8ZofkyberEzmh-ofVGXM4dciGEYA@mail.gmail.com>
	<20160229165031.GY17997@ZenIV.linux.org.uk>
Date: Mon, 29 Feb 2016 09:24:04 -0800
Message-ID: <CA+55aFx_F6vWpCMA3aHWHAdd-2HYZh-FJMUD7mpy3dV8QW3Odg@mail.gmail.com>
Subject: Re: fs: NULL deref in atime_needs_update
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Dmitry Vyukov <dvyukov@google.com>, Ian Kent <raven@themaw.net>,
	=?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	syzkaller <syzkaller@googlegroups.com>,
	Kostya Serebryany <kcc@google.com>,
	Alexander Potapenko <glider@google.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	David Howells <dhowells@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Feb 29, 2016 at 8:50 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> In __d_entry_type(), you mean?  Should be, along with READ_ONCE() there.
> AFAICS, ordering shouldn't be an issue anymore...

That's the one.

It results in those barriers in very subtle places, and it was always
unclear whether any of the users of those "d_is_*()" helper functions
really understood the subtle memory ordering involved.

The smp_rmb() is also potentially quite expensive on some architectures.

So getting rid of those hidden memory orderings would be a goodness
quite apart from fixing the bug Dmitry found.

                   Linus