linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Doug Ledford <dledford@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	Mike Marciniszyn <infinipath@intel.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	ira weiny <ira.weiny@intel.com>,
	Jubin John <jubin.john@intel.com>
Subject: Re: [WTF] utterly tasteless ABI in hfi1 (around ->write()/->write_iter())
Date: Wed, 16 Mar 2016 09:36:46 -0700	[thread overview]
Message-ID: <CA+55aFxzJcBFG758ZD5E=c8m8G5WUhyPXRr1fTH+PgBJeqsMcQ@mail.gmail.com> (raw)
In-Reply-To: <56E97FD7.9020007@redhat.com>

On Wed, Mar 16, 2016 at 8:46 AM, Doug Ledford <dledford@redhat.com> wrote:
>
> If we want to maintain back compatibility, then the qib driver has to
> maintain this interface. We could possibly do a new one as well, but we
> can't remove this one.

We've broken more important driver ABI's before - all the nasty X stuff.

Now, the X people did learn their lesson, and it hasn't happened
lately (thank Gods!), but quite frankly, some shit-for-brains
hardware-specific config interface for a rdma device that basically
nobody uses is a _lot_ less important than X ever was.

So I don't care one whit if we break it, and it's not the kind of
backwards compatibility the kernel should worry about. There are
exactly zero regular users of this interface. I assume that people who
use this thing are *so* deeply technical that they can take care of
themselves. And it really is a completely broken interface.

I might be proven wrong, and somebody's dear old grandma ends up
complaining about a new kernel breaking her configuration, and in that
case we'd have to revert anything that causes that breakage. But I
suspect I'm not wrong.

                  Linus

  parent reply	other threads:[~2016-03-16 16:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  4:17 [WTF] utterly tasteless ABI in hfi1 (around ->write()/->write_iter()) Al Viro
2016-03-16  4:34 ` Linus Torvalds
2016-03-16 15:46 ` Doug Ledford
2016-03-16 16:02   ` Theodore Ts'o
2016-03-16 16:36   ` Linus Torvalds [this message]
2016-03-16 17:06     ` Al Viro
     [not found]   ` <20160316220029.GA5213@scvm10.sc.intel.com>
2016-03-16 22:52     ` Dalessandro, Dennis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFxzJcBFG758ZD5E=c8m8G5WUhyPXRr1fTH+PgBJeqsMcQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jubin.john@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).