From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-aio@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes)
Date: Sat, 29 Oct 2016 13:09:25 -0700 [thread overview]
Message-ID: <CA+55aFy3rYRDSHGfxrF-nTRKoxHB1-Kk63Z3xDN3cSRLbx1BbA@mail.gmail.com> (raw)
In-Reply-To: <20161029191753.GU19539@ZenIV.linux.org.uk>
On Sat, Oct 29, 2016 at 12:17 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> AFAICS, the possibility of dropping the last reference to struct file
> before ->write_iter() has returned is fundamentally broken. I might be
> missing something subtle here, but...
Ok, let's add a get_file(); fput(); around that whole iter call sequence.
And that's a separate issue from "we should hold the fs freezer lock
around the whole operation". So I think we need both.
Does that make everybody happy?
Linus
next prev parent reply other threads:[~2016-10-29 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 7:44 aio: fix a user triggered use after free Christoph Hellwig
2016-10-29 7:44 ` [PATCH] aio: fix a user triggered use after free (and fix freeze protection of aio writes) Christoph Hellwig
2016-10-29 12:24 ` Al Viro
2016-10-29 15:20 ` Christoph Hellwig
2016-10-29 16:12 ` Al Viro
2016-10-29 16:29 ` Al Viro
2016-10-30 6:32 ` Christoph Hellwig
2016-10-29 17:47 ` Linus Torvalds
2016-10-29 18:52 ` Al Viro
2016-10-29 19:07 ` Linus Torvalds
2016-10-29 19:17 ` Al Viro
2016-10-29 20:09 ` Linus Torvalds [this message]
2016-10-30 9:44 ` Jan Kara
2016-10-30 10:52 ` Jan Kara
2016-10-30 15:58 ` Christoph Hellwig
2016-10-30 6:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFy3rYRDSHGfxrF-nTRKoxHB1-Kk63Z3xDN3cSRLbx1BbA@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=dmonakhov@openvz.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).