From: Linus Torvalds <torvalds@linux-foundation.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-unionfs@vger.kernel.org
Subject: Re: [GIT PULL] overlayfs update for 4.9
Date: Thu, 13 Oct 2016 21:03:23 -0700 [thread overview]
Message-ID: <CA+55aFyEtF-t5rbbOtAz1+Rdxcbbt+CTrWJWPg1+TViq+DoLCQ@mail.gmail.com> (raw)
In-Reply-To: <20161013143751.GE31239@veci.piliscsaba.szeredi.hu>
On Thu, Oct 13, 2016 at 7:37 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> Please pull from:
No.
Or rather, I pulled and then immediately unpulled. When I look at the
diff, I saw an obvious bug in the very first chunk. I'm not going to
pull something that is this obviously buggy and untested.
Your change to fs/ioctl.c to add a -EXDEV error case very clearly
leaks a reference to 'src_file'.
It's too late in the merge window for this to be fixed up any more.
This has been a painful enough merge window for me that I'm not going
to play around with obviously buggy pull requests.
Linus
next prev parent reply other threads:[~2016-10-14 4:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 14:37 [GIT PULL] overlayfs update for 4.9 Miklos Szeredi
2016-10-13 14:51 ` Miklos Szeredi
2016-10-14 4:03 ` Linus Torvalds [this message]
2016-10-14 6:19 ` Sedat Dilek
2016-10-14 6:48 ` Amir Goldstein
2016-10-14 10:10 ` Amir Goldstein
-- strict thread matches above, loose matches on Subject: below --
2016-10-05 19:52 Miklos Szeredi
2016-10-05 20:06 ` Al Viro
2016-10-05 23:49 ` Al Viro
2016-10-06 8:01 ` Miklos Szeredi
2016-10-11 19:49 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFyEtF-t5rbbOtAz1+Rdxcbbt+CTrWJWPg1+TViq+DoLCQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).