From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [GIT PULL] direct IO support for loop driver Date: Wed, 20 Nov 2013 13:19:33 -0800 Message-ID: References: <528A648F.1030007@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Christoph Hellwig , LKML , "linux-fsdevel@vger.kernel.org" , "Maxim V. Patlasov" , linux-aio@kvack.org, Kent Overstreet , Jens Axboe To: Dave Kleikamp Return-path: In-Reply-To: <528A648F.1030007@oracle.com> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 18, 2013 at 11:03 AM, Dave Kleikamp wrote: > Linus, > > Please pull the following patches. They add the infrastructure for > kernel-initiated direct-io, change the loop driver to perform direct-io, > and change swap-over-nfs to use the new infrastructure. Quite frankly, I got maybe ten patches into this series, at which point I just threw my hands up and said: "This is too ugly to live". The naming in fs/iov-iter.c is disgusting. :ii_iov_xyz? WTF? Random "flag" value for marking things atomic? F*ck me, that's ugly. A separate phase for checking addresses instead of just doing it in the loop that loops over iovec's? Why? It sure as hell isn't because it's more efficient, and it doubly sure as hell isn't because it's prettier. At that point, I just couldn't take it any more. I really don't see the point of all this crap. All this for the loop driver? If so, it had better at least be prettier than it is. Linus -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org