From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [SECOND RESEND] vfs: Return -ENXIO for negative SEEK_HOLE / SEEK_DATA offsets
Date: Tue, 26 Sep 2017 10:12:46 -0700 [thread overview]
Message-ID: <CA+55aFyLfmdHWO_n7c6LojifAx4_89Et+0704_Vet1+CE8yhXQ@mail.gmail.com> (raw)
In-Reply-To: <20170925102303.8288-1-agruenba@redhat.com>
On Mon, Sep 25, 2017 at 3:23 AM, Andreas Gruenbacher
<agruenba@redhat.com> wrote:
>
> could you please merge the following VFS fix, sent to Al etc. on August
> 30 and resent on September 14, with no reaction?
This fix seems wrong, or at least misleading.
We already error out for negative offsets in vfs_setpos(), except for
the special case of /proc/<pid>/mem, /dev/mem and /dev/kmem (which
have that FMODE_UNSIGNED_OFFSET special case).
Sure, the error is different (-EINVAL), but that doesn't seem wrong.
So my gut feel is that if xfstest generic/448 cares about EINVAL vs
ENXIO, then that test is just garbage. Because let's face it, EINVAL
is the *normal* error return for negative offsets.
Am I missing something?
Linus
next prev parent reply other threads:[~2017-09-26 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 10:23 [SECOND RESEND] vfs: Return -ENXIO for negative SEEK_HOLE / SEEK_DATA offsets Andreas Gruenbacher
2017-09-26 17:12 ` Linus Torvalds [this message]
2017-09-26 18:48 ` Andreas Gruenbacher
2017-09-26 20:45 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFyLfmdHWO_n7c6LojifAx4_89Et+0704_Vet1+CE8yhXQ@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=agruenba@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).