From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Oleg Nesterov <oleg@redhat.com>, Will Drewry <wad@chromium.org>,
linux-kernel@vger.kernel.org, keescook@chromium.org,
john.johansen@canonical.com, serge.hallyn@canonical.com,
coreyb@linux.vnet.ibm.com, pmoore@redhat.com, eparis@redhat.com,
djm@mindrot.org, segoon@openwall.com, rostedt@goodmis.org,
jmorris@namei.org, scarybeasts@gmail.com, avi@redhat.com,
penberg@cs.helsinki.fi, viro@zeniv.linux.org.uk, luto@mit.edu,
mingo@elte.hu, akpm@linux-foundation.org, khilman@ti.com,
borislav.petkov@amd.com, amwang@redhat.com, ak@linux.intel.com,
eric.dumazet@gmail.com, gregkh@suse.de, dhowells@redhat.com,
daniel.lezcano@free.fr, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org, olofj@chromium.org,
mhalcrow@google.com, dlaor@redhat.com, corbet@lwn.net
Subject: Re: [PATCH] Add PR_{GET,SET}_NO_NEW_PRIVS to prevent execve from granting privs
Date: Fri, 13 Jan 2012 12:13:55 -0800 [thread overview]
Message-ID: <CA+55aFyaVyUE7vif_VVcywG6YpBqVsY=qT0DsZiecNQnx_ddSQ@mail.gmail.com> (raw)
In-Reply-To: <CALCETrU=7Xs_Kf1d45=68zbXCkjLVTs9+fUFg58ZZTQZfHZ_1A@mail.gmail.com>
On Fri, Jan 13, 2012 at 12:05 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> I'm confused. The patch does "no security context changes on execve".
So that's what I wanted and thought you did, but your comment:
"With my patch, selinux can already block the execve if it wants"
is what I reacted to. The "selinux *can*" and the "if it wants" part
was what made my hackles rise.
If it is not about what selinux can and what selinux wants, I'm happy.
The security manager shouldn't have any choices in the matter. No
'can', no 'want'.
Your choice of words made me think your patch had left that door open.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-13 20:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 2:12 [PATCH] Add PR_{GET,SET}_NO_NEW_PRIVS to prevent execve from granting privs Andy Lutomirski
2012-01-13 5:58 ` Kees Cook
2012-01-13 6:02 ` Andy Lutomirski
2012-01-13 6:09 ` Kees Cook
2012-01-13 7:27 ` John Johansen
2012-01-13 13:45 ` John Johansen
2012-01-13 16:45 ` Oleg Nesterov
2012-01-13 18:24 ` Alan Cox
2012-01-13 18:54 ` Eric Paris
2012-01-13 19:00 ` Andy Lutomirski
2012-01-13 19:12 ` Linus Torvalds
2012-01-13 19:39 ` Andy Lutomirski
2012-01-13 19:45 ` Linus Torvalds
2012-01-13 20:05 ` Andy Lutomirski
2012-01-13 20:13 ` Linus Torvalds [this message]
2012-01-13 20:19 ` Andy Lutomirski
2012-01-13 20:13 ` Eric Paris
2012-01-13 21:13 ` Linus Torvalds
2012-01-14 13:55 ` Jamie Lokier
2012-01-17 23:57 ` Eric W. Biederman
2012-01-18 0:22 ` Andy Lutomirski
-- strict thread matches above, loose matches on Subject: below --
2012-01-14 15:17 Eric Paris
2012-01-14 16:04 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyaVyUE7vif_VVcywG6YpBqVsY=qT0DsZiecNQnx_ddSQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=amwang@redhat.com \
--cc=avi@redhat.com \
--cc=borislav.petkov@amd.com \
--cc=corbet@lwn.net \
--cc=coreyb@linux.vnet.ibm.com \
--cc=daniel.lezcano@free.fr \
--cc=dhowells@redhat.com \
--cc=djm@mindrot.org \
--cc=dlaor@redhat.com \
--cc=eparis@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=khilman@ti.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@mit.edu \
--cc=mhalcrow@google.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=olofj@chromium.org \
--cc=penberg@cs.helsinki.fi \
--cc=pmoore@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scarybeasts@gmail.com \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).