linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [GIT PULL] Ext3, reiserfs, udf & isofs fixes
Date: Fri, 6 Sep 2013 09:11:18 -0700	[thread overview]
Message-ID: <CA+55aFytAMNADORn4FfUO620OvLdiMRNVhYbVuCFnWgo4kpvjQ@mail.gmail.com> (raw)
In-Reply-To: <20130905195802.GA9260@quack.suse.cz>

On Thu, Sep 5, 2013 at 12:58 PM, Jan Kara <jack@suse.cz> wrote:
>
> udf/isofs changes to refuse mounting fs rw instead of mounting it
> ro automatically which makes eject button work as expected for all media (see
> the changelog for why userspace should be ok with this change).

Pulled. However, these are kind of odd.

For trying _remount_ something read-only, isofs returns the logical
EROFS error code.

But for trying to mount it in the first place, it returns EACCES,
which sounds insane. It's not a permission problem - no amount of
permissions will ever make it work.

UDF always does EACCES, regardless of mount/remount.

Is there some fundamental reason for the insane error code? Does user
space do the wrong thing if we were to just always return "EROFS"
which makes much more sense?

                 Linus

  reply	other threads:[~2013-09-06 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 19:58 [GIT PULL] Ext3, reiserfs, udf & isofs fixes Jan Kara
2013-09-06 16:11 ` Linus Torvalds [this message]
2013-09-09 14:12   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFytAMNADORn4FfUO620OvLdiMRNVhYbVuCFnWgo4kpvjQ@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).