From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow) Date: Wed, 28 Nov 2012 11:53:31 -0800 Message-ID: References: <50B46E05.70906@kernel.dk> <50B4B313.3030707@kernel.dk> <50B5CC5A.8060607@kernel.dk> <20121128194314.GF4939@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Mikulas Patocka , Jens Axboe , Jeff Chua , Lai Jiangshan , Jan Kara , lkml , linux-fsdevel To: Al Viro Return-path: In-Reply-To: <20121128194314.GF4939@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Nov 28, 2012 at 11:43 AM, Al Viro wrote: > Have a > private vm_operations - a copy of generic_file_vm_ops with ->open()/->close() > added to it. That sounds more reasonable. However, I suspect the *most* reasonable thing to do is to just remove the whole damn thing. We really shouldn't care about mmap. If somebody does a mmap on a block device, and somebody else then changes the block size, why-ever should we bother to go through any contortions at *all* to make that kind of insane behavior do anything sane at all. Just let people mmap things. Then just let the normal page cache invalidation work right. In fact, it is entirely possible that we could/should just not even invalidate the page cache at all, just make sure that the buffer heads attached to any pages get disconnected. No? Linus