From: Linus Torvalds <torvalds@linux-foundation.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] next cycle fun: ->release() API change
Date: Sat, 11 May 2013 12:16:22 -0700 [thread overview]
Message-ID: <CA+55aFzsgr6ZHWxNRvM3VZu=bWn75TfGb0EAXO1wdFnBFTCz-Q@mail.gmail.com> (raw)
In-Reply-To: <20130511172242.GP25399@ZenIV.linux.org.uk>
On Sat, May 11, 2013 at 10:22 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>>
>> Because renaming really doesn't buy us anything but pain.
>
> Umm... I'd rather go the whole way and get rid of inode argument as well,
> while we are at it. It's completely redundant and it's unused in very large
> majority of the instances.
So? What's the advantage of removing it?
Also, "->close()" would be *exactly* the wrong name to call this,
since it would be absolutely and utterly misleading. "->release()" is
_not_ about close, and in fact the whole return code is partially due
to people thinking it is. It's "->flush()" that gets called at close
time.
Linus
next prev parent reply other threads:[~2013-05-11 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 5:03 [RFC] next cycle fun: ->release() API change Al Viro
2013-05-11 17:05 ` Linus Torvalds
2013-05-11 17:22 ` Al Viro
2013-05-11 19:16 ` Linus Torvalds [this message]
2013-05-11 21:06 ` Al Viro
2013-05-11 21:12 ` Linus Torvalds
2013-05-12 0:06 ` Al Viro
2013-05-12 21:47 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFzsgr6ZHWxNRvM3VZu=bWn75TfGb0EAXO1wdFnBFTCz-Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).