From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9579B25560 for ; Thu, 4 Jan 2024 16:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="fdn/14QO" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-427f21ced6aso3410531cf.1 for ; Thu, 04 Jan 2024 08:30:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1704385819; x=1704990619; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Aj4IIq0tzuh1/OdFywt45Ed5fBVp3SK/t71RwP6JXSw=; b=fdn/14QOew7x0hZlqE8RvMbT+eay+t99WzcP3kxGSeb8OS5ACFhxqkeI7iB+nyafr0 rOuV6rmqZYe/l+tOjY/F68nb75dV/6faHMawGvHRB8Ise/ZVn0TUmrjcNnDvPpYSKK2u +QXD6hqZOg+6u0V1BppZ1Urc5RWCALe2KqPFw8J3VQOjtx6mSqe/+OUnn1A9CxqXE2Rh 3JFRqVxezB+DuRVhlYCK/igl86QKpIhEethObsm3dCBF1m3uN1ceVfoGd3oqdi0XHpq+ P1ABcTzfX+8k++zN/yVvUWt5pjTlmOe+9OyrAy5cz7M2zWHcj6kYn7fmGKwoBPTTXQfY VfCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704385819; x=1704990619; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Aj4IIq0tzuh1/OdFywt45Ed5fBVp3SK/t71RwP6JXSw=; b=JfzkPilg49fSamxLAMUyZK+1NVD4sMPVadwrZyvtcgJn+2ma2mdLL7ziL5uu5WKutm mLiB13EJj5ga21c5IXsClIJSWxblKSBz2dJKqIozx15axxufPs8Bk7w2OQxfZwt8OFyz CdGaBxKlo0SUIqqq6rx8yTSogNuQiGxHBX3VpZgVmH8dFDXm1ilj4iAa78vnsdwtnac/ keXvfArNH7g+S6/GuYMAqkrGk1I9sZfWTSEuchH0VrHHb87HRiecZ6Bmv782Yy0RuDI1 QZbo51nWyCLQqNJHbBXmke+CrptJo2qlN0RJLatkzM9l3sxboebqPHiN7oW+q1EuEJIc 4AnA== X-Gm-Message-State: AOJu0YwCEFnjAUDxg9v+vqbvmqNHUsfir4TdgPuA6wPKd+8lRapAuX/d 9CdVP63FD648WuE5jnlagkyRdYGWeBn+7Z+pV/WNn8UGJRW5jg== X-Google-Smtp-Source: AGHT+IHbmPwv6z7KPbpI44YRa4bYQfIXyvmSunk5ru1UyVqC5KptkTXxtDOkWoeYljsAtoXlTJC88ShSxszX3+BvyHo= X-Received: by 2002:ac8:5cce:0:b0:428:3602:4ad8 with SMTP id s14-20020ac85cce000000b0042836024ad8mr839527qta.60.1704385819426; Thu, 04 Jan 2024 08:30:19 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231226200205.562565-1-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 4 Jan 2024 11:29:43 -0500 Message-ID: Subject: Re: [PATCH v3 00/10] IOMMU memory observability To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: akpm@linux-foundation.org, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com, rientjes@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 4, 2024 at 10:31=E2=80=AFAM Michal Koutn=C3=BD wrote: > > Hello. > > On Tue, Dec 26, 2023 at 08:01:55PM +0000, Pasha Tatashin wrote: > > This patch series solves this problem by adding both observability to > > all pages that are allocated by IOMMU, and also accountability, so > > admins can limit the amount if via cgroups. > > Maybe this is a mismatch in vocabulary what you mean by the verb > "limit". But I don't see in the patchset that the offending pages would > be allocated with GFP_ACCOUNT. So the result is that the pages are > accounted (you can view the amount in memory.stat) but they are not > subject to memcg limits. > > Is that what you intend? Hi Michal, Thank you for taking a look at this. The two patches [1] [2] which add GFP_KERNEL_ACCOUNT were sent separate from this series at request of reviewers: Pasha [1] https://lore.kernel.org/linux-mm/20231226182827.294158-1-pasha.tatashin= @soleen.com [2] https://lore.kernel.org/linux-mm/20231130200900.2320829-1-pasha.tatashi= n@soleen.com > > > Regards, > Michal