Re: [PATCH 6.16 000/564] 6.16.2-rc2 review

Re: [PATCH 6.16 000/564] 6.16.2-rc2 review

[Naresh Kamboju]

On Tue, 19 Aug 2025 at 18:02, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 6.16.2 release.
> There are 564 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 21 Aug 2025 12:27:23 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.16.2-rc2.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

As I have reported last week on 6.16.1-rc1 as regression is
still noticed on 6.16.2-rc2.

WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334 start_this_handle

Full test log:
------------[ cut here ]------------
[  153.965287] WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334
start_this_handle+0x4df/0x500
[  153.966304] Modules linked in: tun fuse
[  153.967547] CPU: 0 UID: 0 PID: 7012 Comm: quotacheck Not tainted
6.16.2-rc2 #1 PREEMPT(voluntary)
[  153.968294] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009),
BIOS 1.16.3-debian-1.16.3-2 04/01/2014
[  153.969408] RIP: 0010:start_this_handle+0x4df/0x500
[  153.970243] Code: e9 5b fc ff ff 90 0f 0b 8b 4d a4 65 48 8b 05 a0
27 17 02 48 c7 c7 70 f2 87 ac 8b 55 a0 48 8d b0 c0 07 00 00 e8 a2 09
c7 ff 90 <0f> 0b 90 41 b8 e4 ff ff ff e9 a7 fc ff ff e8 0e c9 e2 00 0f
1f 00
[  153.971734] RSP: 0018:ffffabfb0112bb60 EFLAGS: 00010246
[  153.972336] RAX: 0000000000000049 RBX: ffff93cf8706a800 RCX: 0000000000000000
[  153.973157] RDX: 0000000000000000 RSI: ffffffffaae64a70 RDI: ffffffffaae64a70
[  153.973347] RBP: ffffabfb0112bbd0 R08: 00000000ffffdfff R09: ffffffffacc7c880
[  153.973513] R10: 0000000000000003 R11: ffffffffacc7c880 R12: ffff93cf8706a800
[  153.974263] R13: ffff93cf8044f6c8 R14: 0000000000000000 R15: 0000000000000002
[  153.975058] FS:  00007f245e2d5780(0000) GS:ffff93d04e8ae000(0000)
knlGS:0000000000000000
[  153.975933] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  153.976641] CR2: 00007ff069065690 CR3: 0000000106a0a000 CR4: 00000000000006f0
[  153.977841] Call Trace:
[  153.978279]  <TASK>
[  153.978748]  ? kmem_cache_alloc_noprof+0x119/0x3d0
[  153.979180]  ? __folio_batch_add_and_move+0xb5/0x100
[  153.979691]  jbd2__journal_start+0xfd/0x1f0
[  153.980154]  __ext4_journal_start_sb+0x10d/0x1a0
[  153.980642]  ext4_write_begin+0x17e/0x510
[  153.981132]  generic_perform_write+0x95/0x290
[  153.981569]  ext4_buffered_write_iter+0x6d/0x120
[  153.982014]  ext4_file_write_iter+0xab/0x820
[  153.982315]  ? selinux_file_permission+0x12d/0x1a0
[  153.982754]  ? trace_preempt_on+0x1e/0x70
[  153.983393]  vfs_write+0x2a8/0x4b0
[  153.983886]  ksys_write+0x7b/0xf0
[  153.984248]  __x64_sys_write+0x1d/0x30
[  153.984510]  x64_sys_call+0x2ab/0x20c0
[  153.985107]  do_syscall_64+0xb2/0x2b0
[  153.985513]  entry_SYSCALL_64_after_hwframe+0x77/0x7f


Lore link:
- https://lore.kernel.org/all/CA+G9fYsyYQ3ZL4xaSg1-Tt5Evto7Zd+hgNWZEa9cQLbahA1+xg@mail.gmail.com/
- https://regressions.linaro.org/lkft/linux-stable-rc-linux-6.16.y/v6.16-1186-gb81166f7d590/log-parser-test/exception-warning-cpu-pid-at-fsjbd2transaction-start_this_handle/

--
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 6.16 000/564] 6.16.2-rc2 review

[Dan Carpenter]

On Wed, Aug 20, 2025 at 08:06:01PM +0530, Naresh Kamboju wrote:
> On Tue, 19 Aug 2025 at 18:02, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 6.16.2 release.
> > There are 564 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 21 Aug 2025 12:27:23 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.16.2-rc2.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.16.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> As I have reported last week on 6.16.1-rc1 as regression is
> still noticed on 6.16.2-rc2.
> 
> WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334 start_this_handle
> 
> Full test log:
> ------------[ cut here ]------------
> [  153.965287] WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334
> start_this_handle+0x4df/0x500

The problem is that we only applied the last two patches in:
https://lore.kernel.org/linux-ext4/20250707140814.542883-1-yi.zhang@huaweicloud.com/

Naresh is on vacation until Monday, but he tested the patchset on
linux-next and it fixed the issues.  So we need to cherry-pick the
following commits.

1bfe6354e097 ext4: process folios writeback in bytes
f922c8c2461b ext4: move the calculation of wbc->nr_to_write to mpage_folio_done()
ded2d726a304 ext4: fix stale data if it bail out of the extents mapping loop
2bddafea3d0d ext4: refactor the block allocation process of ext4_page_mkwrite()
e2c4c49dee64 ext4: restart handle if credits are insufficient during allocating blocks
6b132759b0fe ext4: enhance tracepoints during the folios writeback
95ad8ee45cdb ext4: correct the reserved credits for extent conversion
bbbf150f3f85 ext4: reserved credits for one extent during the folio writeback
57661f28756c ext4: replace ext4_writepage_trans_blocks()

They all apply cleanly to 6.16.3-rc1.

regards,
dan carpenter

Re: [PATCH 6.16 000/564] 6.16.2-rc2 review

[Greg Kroah-Hartman]

On Fri, Aug 22, 2025 at 12:31:00PM +0300, Dan Carpenter wrote:
> On Wed, Aug 20, 2025 at 08:06:01PM +0530, Naresh Kamboju wrote:
> > On Tue, 19 Aug 2025 at 18:02, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 6.16.2 release.
> > > There are 564 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 21 Aug 2025 12:27:23 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.16.2-rc2.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.16.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > 
> > As I have reported last week on 6.16.1-rc1 as regression is
> > still noticed on 6.16.2-rc2.
> > 
> > WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334 start_this_handle
> > 
> > Full test log:
> > ------------[ cut here ]------------
> > [  153.965287] WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334
> > start_this_handle+0x4df/0x500
> 
> The problem is that we only applied the last two patches in:
> https://lore.kernel.org/linux-ext4/20250707140814.542883-1-yi.zhang@huaweicloud.com/
> 
> Naresh is on vacation until Monday, but he tested the patchset on
> linux-next and it fixed the issues.  So we need to cherry-pick the
> following commits.
> 
> 1bfe6354e097 ext4: process folios writeback in bytes
> f922c8c2461b ext4: move the calculation of wbc->nr_to_write to mpage_folio_done()
> ded2d726a304 ext4: fix stale data if it bail out of the extents mapping loop
> 2bddafea3d0d ext4: refactor the block allocation process of ext4_page_mkwrite()
> e2c4c49dee64 ext4: restart handle if credits are insufficient during allocating blocks
> 6b132759b0fe ext4: enhance tracepoints during the folios writeback
> 95ad8ee45cdb ext4: correct the reserved credits for extent conversion
> bbbf150f3f85 ext4: reserved credits for one extent during the folio writeback
> 57661f28756c ext4: replace ext4_writepage_trans_blocks()
> 
> They all apply cleanly to 6.16.3-rc1.

Ugh.  Ok, let me go push out a -rc for JUST this issue now so that
people can test and I can get it released for those that are tripped up
by it.  Thanks for the information, much appreciated.

greg k-h

Re: [PATCH 6.16 000/564] 6.16.2-rc2 review

[Greg Kroah-Hartman]

On Fri, Aug 22, 2025 at 02:14:10PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Aug 22, 2025 at 12:31:00PM +0300, Dan Carpenter wrote:
> > On Wed, Aug 20, 2025 at 08:06:01PM +0530, Naresh Kamboju wrote:
> > > On Tue, 19 Aug 2025 at 18:02, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 6.16.2 release.
> > > > There are 564 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Thu, 21 Aug 2025 12:27:23 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.16.2-rc2.gz
> > > > or in the git tree and branch at:
> > > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.16.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > > 
> > > As I have reported last week on 6.16.1-rc1 as regression is
> > > still noticed on 6.16.2-rc2.
> > > 
> > > WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334 start_this_handle
> > > 
> > > Full test log:
> > > ------------[ cut here ]------------
> > > [  153.965287] WARNING: CPU: 0 PID: 7012 at fs/jbd2/transaction.c:334
> > > start_this_handle+0x4df/0x500
> > 
> > The problem is that we only applied the last two patches in:
> > https://lore.kernel.org/linux-ext4/20250707140814.542883-1-yi.zhang@huaweicloud.com/
> > 
> > Naresh is on vacation until Monday, but he tested the patchset on
> > linux-next and it fixed the issues.  So we need to cherry-pick the
> > following commits.
> > 
> > 1bfe6354e097 ext4: process folios writeback in bytes
> > f922c8c2461b ext4: move the calculation of wbc->nr_to_write to mpage_folio_done()
> > ded2d726a304 ext4: fix stale data if it bail out of the extents mapping loop
> > 2bddafea3d0d ext4: refactor the block allocation process of ext4_page_mkwrite()
> > e2c4c49dee64 ext4: restart handle if credits are insufficient during allocating blocks
> > 6b132759b0fe ext4: enhance tracepoints during the folios writeback
> > 95ad8ee45cdb ext4: correct the reserved credits for extent conversion
> > bbbf150f3f85 ext4: reserved credits for one extent during the folio writeback
> > 57661f28756c ext4: replace ext4_writepage_trans_blocks()
> > 
> > They all apply cleanly to 6.16.3-rc1.
> 
> Ugh.  Ok, let me go push out a -rc for JUST this issue now so that
> people can test and I can get it released for those that are tripped up
> by it.  Thanks for the information, much appreciated.

Now pushed out.