landlock: fs_test: fs_test.c:4524:9: error: initializer element is not a compile-time constant

landlock: fs_test: fs_test.c:4524:9: error: initializer element is not a compile-time constant

[Naresh Kamboju]

While building selftests landlock following warnings / errors noticed on the
Linux next with clang-17.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Build errors:
------------
landlock/fs_test
fs_test.c:4524:9: error: initializer element is not a compile-time constant
 4524 |         .mnt = mnt_tmp,
      |                ^~~~~~~
1 error generated.

Links:
 - https://storage.tuxsuite.com/public/linaro/lkft/builds/2U69ue7AaypfY7eRU4UUygecrDx/

Steps to reproduce:
tuxmake --runtime podman --target-arch arm64 --toolchain clang-17
--kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2U69ue7AaypfY7eRU4UUygecrDx/config
LLVM=1 LLVM_IAS=1 dtbs dtbs-legacy headers kernel kselftest modules

--
Linaro LKFT
https://lkft.linaro.org

Re: landlock: fs_test: fs_test.c:4524:9: error: initializer element is not a compile-time constant

[Nick Desaulniers]

On Thu, Aug 17, 2023 at 3:51 AM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> While building selftests landlock following warnings / errors noticed on the
> Linux next with clang-17.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Build errors:
> ------------
> landlock/fs_test
> fs_test.c:4524:9: error: initializer element is not a compile-time constant

Hi Naresh,
Can you tell me more about your specific version of clang-17?

I believe a fix of mine to clang should address this. It landed in
clang-18, and was backported to clang-17 recently.
https://github.com/llvm/llvm-project-release-prs/commit/0b2d5b967d98375793897295d651f58f6fbd3034

I suspect your clang-17 might need a rebuild.  Thanks for the report.

>  4524 |         .mnt = mnt_tmp,
>       |                ^~~~~~~
> 1 error generated.
>
> Links:
>  - https://storage.tuxsuite.com/public/linaro/lkft/builds/2U69ue7AaypfY7eRU4UUygecrDx/
>
> Steps to reproduce:
> tuxmake --runtime podman --target-arch arm64 --toolchain clang-17
> --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2U69ue7AaypfY7eRU4UUygecrDx/config
> LLVM=1 LLVM_IAS=1 dtbs dtbs-legacy headers kernel kselftest modules
>
> --
> Linaro LKFT
> https://lkft.linaro.org
>


-- 
Thanks,
~Nick Desaulniers

Re: landlock: fs_test: fs_test.c:4524:9: error: initializer element is not a compile-time constant

[Naresh Kamboju]

On Thu, 17 Aug 2023 at 21:24, Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Thu, Aug 17, 2023 at 3:51 AM Naresh Kamboju
> <naresh.kamboju@linaro.org> wrote:
> >
> > While building selftests landlock following warnings / errors noticed on the
> > Linux next with clang-17.
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Build errors:
> > ------------
> > landlock/fs_test
> > fs_test.c:4524:9: error: initializer element is not a compile-time constant
>
> Hi Naresh,
> Can you tell me more about your specific version of clang-17?

    compiler:
        name: clang,
        version: 17.0.0,
        version_full: Debian clang version 17.0.0
(++20230725053429+d0b54bb50e51-1~exp1~20230725173444.1)

>
> I believe a fix of mine to clang should address this. It landed in
> clang-18, and was backported to clang-17 recently.
> https://github.com/llvm/llvm-project-release-prs/commit/0b2d5b967d98375793897295d651f58f6fbd3034
>
> I suspect your clang-17 might need a rebuild.  Thanks for the report.

I will rebuild / re-test and confirm soon.

- Naresh

Re: landlock: fs_test: fs_test.c:4524:9: error: initializer element is not a compile-time constant

[Naresh Kamboju]

On Fri, 18 Aug 2023 at 10:48, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Thu, 17 Aug 2023 at 21:24, Nick Desaulniers <ndesaulniers@google.com> wrote:
> >
> > On Thu, Aug 17, 2023 at 3:51 AM Naresh Kamboju
> > <naresh.kamboju@linaro.org> wrote:
> > >
> > > While building selftests landlock following warnings / errors noticed on the
> > > Linux next with clang-17.
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > Build errors:
> > > ------------
> > > landlock/fs_test
> > > fs_test.c:4524:9: error: initializer element is not a compile-time constant
> >
> > Hi Naresh,
> > Can you tell me more about your specific version of clang-17?
>
>     compiler:
>         name: clang,
>         version: 17.0.0,
>         version_full: Debian clang version 17.0.0
> (++20230725053429+d0b54bb50e51-1~exp1~20230725173444.1)
>
> >
> > I believe a fix of mine to clang should address this. It landed in
> > clang-18, and was backported to clang-17 recently.
> > https://github.com/llvm/llvm-project-release-prs/commit/0b2d5b967d98375793897295d651f58f6fbd3034
> >
> > I suspect your clang-17 might need a rebuild.  Thanks for the report.
>
> I will rebuild / re-test and confirm soon.

LKFT team re-built containers and I have re-tested the builds
and reported build issues has been fixed.

Thank you !

Best regards
Naresh Kamboju

Re: landlock: fs_test: fs_test.c:4524:9: error: initializer element is not a compile-time constant

[Nick Desaulniers]

On Mon, Aug 21, 2023 at 7:20 AM Naresh Kamboju
<naresh.kamboju@linaro.org> wrote:
>
> On Fri, 18 Aug 2023 at 10:48, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > On Thu, 17 Aug 2023 at 21:24, Nick Desaulniers <ndesaulniers@google.com> wrote:
> > >
> > > On Thu, Aug 17, 2023 at 3:51 AM Naresh Kamboju
> > > <naresh.kamboju@linaro.org> wrote:
> > > >
> > > > While building selftests landlock following warnings / errors noticed on the
> > > > Linux next with clang-17.
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > Build errors:
> > > > ------------
> > > > landlock/fs_test
> > > > fs_test.c:4524:9: error: initializer element is not a compile-time constant
> > >
> > > Hi Naresh,
> > > Can you tell me more about your specific version of clang-17?
> >
> >     compiler:
> >         name: clang,
> >         version: 17.0.0,
> >         version_full: Debian clang version 17.0.0
> > (++20230725053429+d0b54bb50e51-1~exp1~20230725173444.1)

Ok, decoding that we have 2023-07-25...

> >
> > >
> > > I believe a fix of mine to clang should address this. It landed in
> > > clang-18, and was backported to clang-17 recently.
> > > https://github.com/llvm/llvm-project-release-prs/commit/0b2d5b967d98375793897295d651f58f6fbd3034

And the backport (that sha above) landed 2023-08-03 so that checks
out.  So yes, the initial report was missing the fix that landed more
recently.

> > >
> > > I suspect your clang-17 might need a rebuild.  Thanks for the report.
> >
> > I will rebuild / re-test and confirm soon.
>
> LKFT team re-built containers and I have re-tested the builds
> and reported build issues has been fixed.
>
> Thank you !

Awesome, thanks for the report and retesting to confirm.

>
> Best regards
> Naresh Kamboju



-- 
Thanks,
~Nick Desaulniers