From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Paul Moore <paul@paul-moore.com>,
Christian Brauner <brauner@kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
Kernel Team <kernel-team@meta.com>,
Sargun Dhillon <sargun@sargun.me>
Subject: Re: [PATCH v12 bpf-next 03/17] bpf: introduce BPF token object
Date: Wed, 6 Dec 2023 10:19:27 -0800 [thread overview]
Message-ID: <CAADnVQLbxWPM1njsE141dQjw2+USd8Ggv80QgY+PgsGRd6FoVA@mail.gmail.com> (raw)
In-Reply-To: <20231130185229.2688956-4-andrii@kernel.org>
On Thu, Nov 30, 2023 at 10:57 AM Andrii Nakryiko <andrii@kernel.org> wrote:
> *
> @@ -901,6 +931,8 @@ enum bpf_cmd {
> BPF_ITER_CREATE,
> BPF_LINK_DETACH,
> BPF_PROG_BIND_MAP,
> + BPF_TOKEN_CREATE,
> + __MAX_BPF_CMD,
> };
Not an issue with this commit. I just noticed that
commit f2e10bff16a0 ("bpf: Add support for BPF_OBJ_GET_INFO_BY_FD for bpf_link")
added MAX_BPF_LINK_TYPE to enum bpf_link_type.
While this commit is correctly adding __MAX_BPF_CMD that
is consistent with old __MAX_BPF_ATTACH_TYPE (added in 2016)
and __MAX_BPF_REG (added in 2014).
I think it would be good to follow up with adding two underscores
to MAX_BPF_LINK_TYPE just to keep things consistent in bpf.h.
next prev parent reply other threads:[~2023-12-06 18:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 18:52 [PATCH v12 bpf-next 00/17] BPF token and BPF FS-based delegation Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 01/17] bpf: align CAP_NET_ADMIN checks with bpf_capable() approach Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 02/17] bpf: add BPF token delegation mount options to BPF FS Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 03/17] bpf: introduce BPF token object Andrii Nakryiko
2023-12-06 18:19 ` Alexei Starovoitov [this message]
2023-12-06 18:24 ` Andrii Nakryiko
2023-12-08 13:41 ` Christian Brauner
2023-12-08 22:39 ` Andrii Nakryiko
2023-12-11 10:03 ` Christian Brauner
2023-11-30 18:52 ` [PATCH v12 bpf-next 04/17] bpf: add BPF token support to BPF_MAP_CREATE command Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 05/17] bpf: add BPF token support to BPF_BTF_LOAD command Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 06/17] bpf: add BPF token support to BPF_PROG_LOAD command Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 07/17] bpf: take into account BPF token when fetching helper protos Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 08/17] bpf: consistently use BPF token throughout BPF verifier logic Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 09/17] bpf,lsm: refactor bpf_prog_alloc/bpf_prog_free LSM hooks Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 10/17] bpf,lsm: refactor bpf_map_alloc/bpf_map_free " Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 11/17] bpf,lsm: add BPF token " Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 12/17] libbpf: add bpf_token_create() API Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 13/17] libbpf: add BPF token support to bpf_map_create() API Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 14/17] libbpf: add BPF token support to bpf_btf_load() API Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 15/17] libbpf: add BPF token support to bpf_prog_load() API Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 16/17] selftests/bpf: add BPF token-enabled tests Andrii Nakryiko
2023-11-30 18:52 ` [PATCH v12 bpf-next 17/17] bpf,selinux: allocate bpf_security_struct per BPF token Andrii Nakryiko
2023-12-06 18:20 ` [PATCH v12 bpf-next 00/17] BPF token and BPF FS-based delegation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQLbxWPM1njsE141dQjw2+USd8Ggv80QgY+PgsGRd6FoVA@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).