From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-yw0-f174.google.com ([209.85.161.174]:35858 "EHLO
        mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752204AbdFNXji (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 14 Jun 2017 19:39:38 -0400
Received: by mail-yw0-f174.google.com with SMTP id l75so9306286ywc.3
        for <linux-fsdevel@vger.kernel.org>; Wed, 14 Jun 2017 16:39:38 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20170614230518.GA4518@birch.djwong.org>
References: <20170614172326.18670-1-tahsin@google.com> <20170614230518.GA4518@birch.djwong.org>
From: Tahsin Erdogan <tahsin@google.com>
Date: Wed, 14 Jun 2017 16:39:37 -0700
Message-ID: <CAAeU0aPBotudmaexDh60tBZUcFYk5ZDE2S9byMdD+u1Q34AXnA@mail.gmail.com>
Subject: Re: [PATCH 29/31] ext4: reserve space for xattr entries/names
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.com>, "Theodore Ts'o" <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Dave Kleikamp <shaggy@kernel.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Mark Fasheh <mfasheh@versity.com>,
        Joel Becker <jlbec@evilplan.org>, Jens Axboe <axboe@fb.com>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        Mike Christie <mchristi@redhat.com>,
        Fabian Frederick <fabf@skynet.be>, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        reiserfs-devel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Jun 14, 2017 at 4:05 PM, Darrick J. Wong
<darrick.wong@oracle.com> wrote:
> Why not just spill the values into their own ea_inodes if we need the
> space?  I guess that has the disadvantage that now we need to reserve
> quite a few more journal credits ((1 inode block, 1 bbitmap block, 1
> ibitmap block, 1 data block) * nr_inline_values) just in case we end up
> spilling all the values.
>

In last week's ext4 conference call we have discussed this problem and
possible solutions. The major concern with spilling/evacuation
approach was the added complexity. We haven't discussed the impact on
journal credits, but that is a valid point too.