From: Daniel Black <daniel@mariadb.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: fcntl(fd, F_SETFL, O_DIRECT) succeeds followed by EINVAL in write
Date: Thu, 27 Jan 2022 10:16:09 +1100 [thread overview]
Message-ID: <CABVffEOQL7rXGufHESgP1snV+=UjiJ1gaD-+59c3NLuNgQPt=g@mail.gmail.com> (raw)
In-Reply-To: <YfHH5HsynuMuFJse@casper.infradead.org>
On Thu, Jan 27, 2022 at 9:15 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, Jan 27, 2022 at 09:03:36AM +1100, Daniel Black wrote:
> > Is it going to be reasonable to expect fcntl(fd, F_SETFL, O_DIRECT) to
> > return EINVAL if O_DIRECT isn't supported?
>
> That is a reasonable expectation. I can't guarantee that we won't have
> bugs, of course ...
Ha, sure.
I've begun to https://kernelci.org/ options to try to catch at least
some of them
pre-release.
> > My problem it seems, I'll see what I can do to get back to using real
> > filesystems more.
>
> Heh. I know Hugh is looking at "supporting" O_DIRECT on tmpfs, at least
> for his internal testing. Not sure what his plans are for merging
> that support.
I'd be happy to see it in that it will remove a long standing cludge
bit of weakly
commented user space code in the fullness of supported kernel lifespans, but
no great urgency.
Thanks Matthew.
next prev parent reply other threads:[~2022-01-26 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 22:05 fcntl(fd, F_SETFL, O_DIRECT) succeeds followed by EINVAL in write Daniel Black
2022-01-26 3:02 ` Matthew Wilcox
2022-01-26 22:03 ` Daniel Black
2022-01-26 22:15 ` Matthew Wilcox
2022-01-26 23:16 ` Daniel Black [this message]
2022-01-27 2:38 ` Daniel Black
2022-01-27 4:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABVffEOQL7rXGufHESgP1snV+=UjiJ1gaD-+59c3NLuNgQPt=g@mail.gmail.com' \
--to=daniel@mariadb.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).