From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D55E6C77B6F for ; Thu, 6 Apr 2023 20:12:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbjDFUMU (ORCPT ); Thu, 6 Apr 2023 16:12:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbjDFUMT (ORCPT ); Thu, 6 Apr 2023 16:12:19 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10887B4 for ; Thu, 6 Apr 2023 13:12:17 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id 11so4115929ejw.0 for ; Thu, 06 Apr 2023 13:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680811935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hfXQEoCgBqadpu6FRThsZsy1nkY1OVsi1rMIvATBeoI=; b=eLh2M2ox7ujSVvQ6g9xvjw/WemChY3P4HRSOdHrdgai9GlQKCSmP0BGwnq2lSAjYEP Fapb2AbNv5Gfj16ljxDNnlAMyzI5zF8Gopik9TnFJMJrPhvTMNEQSsUPsivu74u7bYBh PVi8jp/K5KOpIq2YvkU+sUAuMuZutnSno/fRPjRnq+3Znlb1v3jpvhteI4OL0vRVE4fX Of4a8TIzoVa5/AykJda6kyFA0VO9w3Wul3dP+No2oOAG+TUCa2d9G+ytndgPJ0y1Qqs6 bm09CvYM1UsyGT0YIHH82BvLeQ/dp5BFc+bZLy6J7hbPX/WK/sxIQoDiBcjt9kf3j8cf 1ijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680811935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hfXQEoCgBqadpu6FRThsZsy1nkY1OVsi1rMIvATBeoI=; b=M0q6Q6uQJHdYZorwm5t+HYraDbz+rHoXrpB9gXJSG/Mizr4ibkTlCGsr4ixqxnSf6b 0X3CwKRJ2UjfSUeTZoxyu8IySN0A6iIc0JlSshORAFrkZFgUdFmTxGD4C7Qj3hFKxOb9 thyuf+Pfb4oJR9/HNJHErQQ88SNjvQg8Ak8wF6jF58tmbAWxyJzKHN3nngP2FZSuZLxE 1WVc1HLca89Leo2lE16m4BJ1NqKCsAH0+Gl7w/JnfSsP0TZITXiFKbQn78eD3AgWZ2GS t1KgqCY8TMpU26iVRKD29Oupz5dILVQhCz95O6frEtgBRT4ZF5kzwL2oqcpr3v44/Qvi jCag== X-Gm-Message-State: AAQBX9dm102OCj3R2onl9Z4wAppFW8E0TcLl6T81SRYndUW360yzRw80 bVATVEqCS4h8NaBKdhoHW57MSVKwYqO48El8YH+egg== X-Google-Smtp-Source: AKy350YWTiBKhF69rS3s7/XUdyc2hKHku2MPzilut5tCz5P9UctIFCxaz2a8OpRCWENJH0p1saUwx/M1YK9rBFquknE= X-Received: by 2002:a17:906:138c:b0:93e:186f:ea0d with SMTP id f12-20020a170906138c00b0093e186fea0dmr22597ejc.15.1680811935410; Thu, 06 Apr 2023 13:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20230406074005.1784728-1-usama.anjum@collabora.com> <20230406074005.1784728-3-usama.anjum@collabora.com> In-Reply-To: <20230406074005.1784728-3-usama.anjum@collabora.com> From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Date: Thu, 6 Apr 2023 22:12:03 +0200 Message-ID: Subject: Re: [PATCH v12 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 6 Apr 2023 at 09:40, Muhammad Usama Anjum wrote: [...] > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c [...] > +static int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start, > + unsigned long end, struct mm_walk *walk= ) > +{ > + struct pagemap_scan_private *p =3D walk->private; > + bool is_written, is_file, is_present, is_swap; > + struct vm_area_struct *vma =3D walk->vma; > + unsigned long addr =3D end; > + spinlock_t *ptl; > + int ret =3D 0; > + pte_t *pte; > + > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > + ptl =3D pmd_trans_huge_lock(pmd, vma); > + if (ptl) { [...] > + return ret; > + } > +process_smaller_pages: > + if (pmd_trans_unstable(pmd)) > + return 0; Why pmd_trans_unstable() is needed here and not only after split_huge_pmd()= ? Best regards Micha=C5=82 Miros=C5=82aw