From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F35EB64DD for ; Wed, 21 Jun 2023 13:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232645AbjFUNmg (ORCPT ); Wed, 21 Jun 2023 09:42:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbjFUNme (ORCPT ); Wed, 21 Jun 2023 09:42:34 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08EB61998 for ; Wed, 21 Jun 2023 06:42:33 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-516500163b2so3214a12.1 for ; Wed, 21 Jun 2023 06:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687354951; x=1689946951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=acPAMDZruYemX8TV6cTFFhShCBAic/MFb6BfUxW/eJ8=; b=sIctj19+4iS+N71smDAtyzFiXlzPZiOW+G6z39xane6Zv//qrUMsCz6nAa7J6rV7AC b9Jkx0V70uzOFA8gjwzskpQqkQ4Ukl3fYwTxBHAEaFMtCEOImHM7hEt+2d/UvfLorHs0 4E1pwirARjhBK//tyNLrThGOxKwhf8L7gVbhpGvtGoDCGkas9ROaw3nofqrra8OREG1m aC+ioXYVUWJA9heR/2mhaSbQMckdie99gPv4K3MUVGFZVhmZLWUa4UscoMWhoa08jzae PCAeOpYXF+j2zdZD0b/8Q/x7fn08yK7Tm3Q0H2oFC/DCBLrlrhJpxBsjUT9YlpgTarMt d/DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687354951; x=1689946951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acPAMDZruYemX8TV6cTFFhShCBAic/MFb6BfUxW/eJ8=; b=RUf0HB9G89F8UsFa8GyZlgFh997JPSy2fkLzhb0hxK6Y1c9o9GBBbFq0OSBFYOZIqV xVzVivjnhfticfkUlMiFbRLOuPB2aMNTTGBGO7dhACXe3utO4q0fpBLltdIlCl7Tjgpr ZZAuNBu5PJb0JPdRRT1OFSPu9EBOp3UmgBaRuc9qOvAqkxZUEGx930qAMy/XjrP0D8Vs 6I2CKgVTRiyMm6a+50xOGP7LANfn1OImwdn6dMxxVMiE0AojMs4TKFO0TveWmq0caMUC YQzGoqAUqRhHZDnGVTcchIzjShVmq8WTZTOC0VQbKjKhCiY4SoM8IfhuT7gRJwnu/5oH phFA== X-Gm-Message-State: AC+VfDyvKHN15C+ropfLAFlB0HqXzbtLh+RfYfiOkfluYg+7OpUtPm9U NXOmM8ilZWDJtLerwj3y0cS6vt27SZn43AixFGGWBA== X-Google-Smtp-Source: ACHHUZ5UHF11eJAlQXvvGM7fzyvA2yQYbNg05LXVZvb+ql5FzKqus823wT1co33vViD1konnn7jxrblfw3QsQIOgWL8= X-Received: by 2002:a50:d59a:0:b0:51a:1fd1:952f with SMTP id v26-20020a50d59a000000b0051a1fd1952fmr632263edi.1.1687354951319; Wed, 21 Jun 2023 06:42:31 -0700 (PDT) MIME-Version: 1.0 References: <20230621072404.2918101-1-usama.anjum@collabora.com> <20230621072404.2918101-3-usama.anjum@collabora.com> In-Reply-To: <20230621072404.2918101-3-usama.anjum@collabora.com> From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Date: Wed, 21 Jun 2023 15:42:20 +0200 Message-ID: Subject: Re: [PATCH v20 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, 21 Jun 2023 at 09:24, Muhammad Usama Anjum wrote: [...] > +static int pagemap_scan_test_walk(unsigned long start, unsigned long end= , > + struct mm_walk *walk) > +{ > + struct pagemap_scan_private *p =3D walk->private; > + struct vm_area_struct *vma =3D walk->vma; > + > + if ((p->flags & PM_SCAN_REQUIRE_UFFD) && (!userfaultfd_wp_async(v= ma) || > + !userfaultfd_wp_use_markers(vma))) > + return -EPERM; > + > + if (vma->vm_flags & VM_PFNMAP) > + return 1; > + > + return 0; > +} This could actually short-circuit all vma flags (e.g. IS_FILE): if (required_mask & IS_FILE && vma is not file-backed) return 0; Best Regards Micha=C5=82 Miros=C5=82aw