From: Deepa Dinamani <deepa.kernel@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Alexander Viro <viro@zeniv.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
y2038 Mailman List <y2038@lists.linaro.org>
Subject: Re: [PATCH v3 4/5] vfs: Add timestamp_truncate() api
Date: Tue, 21 Feb 2017 10:18:04 -0800 [thread overview]
Message-ID: <CABeXuvr0nZFzMLZPmxTz9EPRTW0-iLtsRr7jRPynceD2ZR_rRg@mail.gmail.com> (raw)
In-Reply-To: <201702191425.I1Iniitc%fengguang.wu@intel.com>
>>> fs/inode.c:2125: warning: Excess function parameter 'gran' description in 'timestamp_truncate'
> 2116 /**
> 2117 * fs_timespec_trunc - Truncate timespec to a granularity
> 2118 * @t: Timespec
> 2119 * @gran: Granularity in ns.
> 2120 *
> 2121 * Truncate a timespec to a granularity. Always rounds down. gran must
> 2122 * not be 0 nor greater than a second (NSEC_PER_SEC, or 10^9 ns).
> 2123 */
> 2124 struct timespec timestamp_truncate(struct timespec t, struct inode *inode)
>> 2125 {
> 2126 struct super_block *sb = inode->i_sb;
> 2127 unsigned int gran = sb->s_time_gran;
This because the comment does not match the actual function signature:
The gran param mentioned in the comment is not actually part of
function signature.
I will fix the comment in the next version.
-Deepa
next prev parent reply other threads:[~2017-02-21 18:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 23:30 [PATCH v3 0/5] vfs: Add timestamp range check support Deepa Dinamani
2017-02-18 23:30 ` [PATCH v3 1/5] vfs: Add file timestamp range support Deepa Dinamani
2017-02-19 1:56 ` Al Viro
2017-02-19 19:23 ` Deepa Dinamani
2017-02-18 23:30 ` [PATCH v3 2/5] vfs: Add checks for filesystem timestamp limits Deepa Dinamani
2017-02-18 23:30 ` [PATCH v3 3/5] ext4: Initialize timestamps limits Deepa Dinamani
2017-02-18 23:30 ` [PATCH v3 4/5] vfs: Add timestamp_truncate() api Deepa Dinamani
2017-02-19 6:26 ` kbuild test robot
2017-02-21 18:18 ` Deepa Dinamani [this message]
2017-02-18 23:30 ` [PATCH v3 5/5] utimes: Clamp the timestamps before update Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABeXuvr0nZFzMLZPmxTz9EPRTW0-iLtsRr7jRPynceD2ZR_rRg@mail.gmail.com \
--to=deepa.kernel@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=kbuild-all@01.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).