From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Antonov Subject: Re: [PATCH] hfsplus: fix "unused node is not erased" error Date: Thu, 22 May 2014 15:25:32 +0200 Message-ID: References: <1400703162.58161.BPMail_high_noncarrier@web172302.mail.ir2.yahoo.com> <1400740185.2427.5.camel@slavad-CELSIUS-H720> <20140522000757.7d8cdad4.akpm@linux-foundation.org> <1400764387.4026.16.camel@slavad-CELSIUS-H720> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Andrew Morton , Hin-Tak Leung , "linux-fsdevel@vger.kernel.org" , Anton Altaparmakov , Al Viro , Christoph Hellwig , Kyle Laracey To: Vyacheslav Dubeyko Return-path: Received: from mail-oa0-f41.google.com ([209.85.219.41]:57519 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752313AbaEVNZd (ORCPT ); Thu, 22 May 2014 09:25:33 -0400 Received: by mail-oa0-f41.google.com with SMTP id m1so3972526oag.28 for ; Thu, 22 May 2014 06:25:32 -0700 (PDT) In-Reply-To: <1400764387.4026.16.camel@slavad-CELSIUS-H720> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 22 May 2014 15:13, Vyacheslav Dubeyko wrote: > On Thu, 2014-05-22 at 14:48 +0200, Sergei Antonov wrote: > > [snip] >> fs/hfsplus/hfsplus_fs.h | 208 +++++++++++++++++++++++++----------------------- >> 1 file changed, 109 insertions(+), 99 deletions(-) >> >> diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h >> index 3c872b2..f917fe4 100644 >> --- a/fs/hfsplus/hfsplus_fs.h >> +++ b/fs/hfsplus/hfsplus_fs.h >> @@ -369,129 +369,139 @@ typedef int (*search_strategy_t)(struct hfs_bnode *, >> /* attributes.c */ >> int __init hfsplus_create_attr_tree_cache(void); >> void hfsplus_destroy_attr_tree_cache(void); >> +int hfsplus_attr_bin_cmp_key(const hfsplus_btree_key *k1, >> + const hfsplus_btree_key *k2); >> +int hfsplus_attr_build_key(struct super_block *sb, hfsplus_btree_key *key, >> + u32 cnid, const char *name); >> +void hfsplus_attr_build_key_uni(hfsplus_btree_key *key, u32 cnid, >> + struct hfsplus_attr_unistr *name); > > As I remember, this function was deleted recently. Could you check it? This function exists in the Linus's tree. Should I have done a patch against linux-next?