From: Dmitry Vyukov <dvyukov@google.com>
To: Zefan Li <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
jweiner@fb.com, LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: cgroup: WARNING in cgroup_kill_sb
Date: Thu, 9 Mar 2017 10:48:28 +0100 [thread overview]
Message-ID: <CACT4Y+asv7gEEFvq1RunCwUE40mTobuqN_8ahwo9K-QaqP547w@mail.gmail.com> (raw)
In-Reply-To: <58C11F61.1090804@huawei.com>
On Thu, Mar 9, 2017 at 10:24 AM, Zefan Li <lizefan@huawei.com> wrote:
> On 2017/3/3 3:15, Dmitry Vyukov wrote:
>> Hello,
>>
>> The following program triggers WARNING in cgroup_kill_sb:
>> https://gist.githubusercontent.com/dvyukov/47a37d3b899ece1f57e512dc6c90bca6/raw/250894f3d6e2954eed01bac39e4c3b7ec59a9c31/gistfile1.txt
>>
>>
>> WARNING: CPU: 2 PID: 3092 at lib/percpu-refcount.c:317
>> percpu_ref_kill_and_confirm+0x3ff/0x4f0 lib/percpu-refcount.c:316
>> percpu_ref_kill_and_confirm called more than once on css_release!
>> Kernel panic - not syncing: panic_on_warn set ...
>>
>> CPU: 2 PID: 3092 Comm: a.out Not tainted 4.10.0+ #260
>> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
>> Call Trace:
>> __dump_stack lib/dump_stack.c:15 [inline]
>> dump_stack+0x2ee/0x3ef lib/dump_stack.c:51
>> panic+0x1fb/0x412 kernel/panic.c:179
>> __warn+0x1c4/0x1e0 kernel/panic.c:540
>> warn_slowpath_fmt+0xc5/0x100 kernel/panic.c:563
>> percpu_ref_kill_and_confirm+0x3ff/0x4f0 lib/percpu-refcount.c:316
>> percpu_ref_kill include/linux/percpu-refcount.h:119 [inline]
>> cgroup_kill_sb+0x188/0x530 kernel/cgroup/cgroup.c:1833
>> deactivate_locked_super+0x88/0xd0 fs/super.c:309
>> deactivate_super+0x155/0x1b0 fs/super.c:340
>> cleanup_mnt+0xb2/0x160 fs/namespace.c:1112
>> __cleanup_mnt+0x16/0x20 fs/namespace.c:1119
>> task_work_run+0x18a/0x260 kernel/task_work.c:116
>> tracehook_notify_resume include/linux/tracehook.h:191 [inline]
>> exit_to_usermode_loop+0x23b/0x2a0 arch/x86/entry/common.c:160
>> prepare_exit_to_usermode arch/x86/entry/common.c:190 [inline]
>> syscall_return_slowpath+0x4d3/0x570 arch/x86/entry/common.c:259
>> entry_SYSCALL_64_fastpath+0xc0/0xc2
>> RIP: 0033:0x440b39
>> RSP: 002b:00007f3e8bd0cdb8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5
>> RAX: ffffffffffffffec RBX: 0000000000000000 RCX: 0000000000440b39
>> RDX: 00000000004a0f3b RSI: 00000000004a0f34 RDI: 00000000004a0f34
>> RBP: 00007f3e8bd0cdd0 R08: 0000000000000000 R09: 0000000000000000
>> R10: 0000000000000005 R11: 0000000000000202 R12: 0000000000000000
>> R13: 0000000000000000 R14: 00007f3e8bd0d9c0 R15: 00007f3e8bd0d700
>>
>> On commit 4977ab6e92e267afe9d8f78438c3db330ca8434c
>> .
>
> could you share your kernel config? I can't reproduce this bug.
It's attached to the previous email.
Run the repro for longer, it's some kind of race.
prev parent reply other threads:[~2017-03-09 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 19:15 cgroup: WARNING in cgroup_kill_sb Dmitry Vyukov
2017-03-06 21:55 ` Tejun Heo
2017-03-07 9:11 ` Dmitry Vyukov
2017-03-07 19:45 ` Tejun Heo
2017-03-07 19:52 ` Dmitry Vyukov
2017-03-09 9:24 ` Zefan Li
2017-03-09 9:48 ` Dmitry Vyukov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+asv7gEEFvq1RunCwUE40mTobuqN_8ahwo9K-QaqP547w@mail.gmail.com \
--to=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=jweiner@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=syzkaller@googlegroups.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).