From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Sahrawat Subject: Re: [PATCH] fs : remove unneeded plug in mpage_readpages. Date: Thu, 17 Nov 2011 14:22:52 +0530 Message-ID: References: <1321026853-16388-1-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Namjae Jeon Return-path: In-Reply-To: <1321026853-16388-1-git-send-email-linkinjeon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Any feedback for this patch? Thanks & Regards, Amit Sahrawat On Fri, Nov 11, 2011 at 9:24 PM, Namjae Jeon wro= te: > block plug in mpage_readpages is duplicated with plug of read_pages. = So block plug is not needed in mpage_readpages. > > Signed-off-by: Namjae Jeon > Signed-off-by: Amit Sahrawat > --- > =A0fs/mpage.c | =A0 =A04 ---- > =A01 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/fs/mpage.c b/fs/mpage.c > index fdfae9f..643e9f5 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -371,9 +371,6 @@ mpage_readpages(struct address_space *mapping, st= ruct list_head *pages, > =A0 =A0 =A0 =A0sector_t last_block_in_bio =3D 0; > =A0 =A0 =A0 =A0struct buffer_head map_bh; > =A0 =A0 =A0 =A0unsigned long first_logical_block =3D 0; > - =A0 =A0 =A0 struct blk_plug plug; > - > - =A0 =A0 =A0 blk_start_plug(&plug); > > =A0 =A0 =A0 =A0map_bh.b_state =3D 0; > =A0 =A0 =A0 =A0map_bh.b_size =3D 0; > @@ -395,7 +392,6 @@ mpage_readpages(struct address_space *mapping, st= ruct list_head *pages, > =A0 =A0 =A0 =A0BUG_ON(!list_empty(pages)); > =A0 =A0 =A0 =A0if (bio) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mpage_bio_submit(READ, bio); > - =A0 =A0 =A0 blk_finish_plug(&plug); > =A0 =A0 =A0 =A0return 0; > =A0} > =A0EXPORT_SYMBOL(mpage_readpages); > -- > 1.7.4.4 > >