From: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
To: Thanos Makatos <thanos.makatos@citrix.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"smfrench@gmail.com" <smfrench@gmail.com>
Subject: Re: O_DIRECT not working with vers=3.0
Date: Sat, 24 Jan 2015 18:15:36 -0600 [thread overview]
Message-ID: <CADT32eLEjvVKNmLS0WMLMvUQC2On9W+fcW58LiMyVNAtaSAAkQ@mail.gmail.com> (raw)
In-Reply-To: <2368A3FCF9F7214298E53C823B0A48EC042F1727@AMSPEX01CL02.citrite.net>
All cifs_direct_io does is return -EINVAL
On Thu, Jan 22, 2015 at 11:13 AM, Thanos Makatos
<thanos.makatos@citrix.com> wrote:
> In dca692880e887739a669f6c41a80ca68ce2b09fc I see that ".direct_IO = cifs_direct_io" is added only to "cifs_addr_ops" but not to "cifs_addr_ops_smallbuf".
> Presuming that the only difference between the two structs is the size of the buffer they operate on (judging by the name), shouldn't ".direct_IO = cifs_direct_io" be added to "cifs_addr_ops_smallbuf" as well?
> In a test environment an open(2) using O_DIRECT didn't work (vers=3.0) but when I added ".direct_IO = cifs_direct_io" to "cifs_addr_ops_smallbuf" it worked.
>
> --
> Thanos Makatos--
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-01-25 0:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 17:13 O_DIRECT not working with vers=3.0 Thanos Makatos
2015-01-25 0:15 ` Shirish Pargaonkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADT32eLEjvVKNmLS0WMLMvUQC2On9W+fcW58LiMyVNAtaSAAkQ@mail.gmail.com \
--to=shirishpargaonkar@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=thanos.makatos@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).