* O_DIRECT not working with vers=3.0
@ 2015-01-22 17:13 Thanos Makatos
2015-01-25 0:15 ` Shirish Pargaonkar
0 siblings, 1 reply; 2+ messages in thread
From: Thanos Makatos @ 2015-01-22 17:13 UTC (permalink / raw)
To: linux-fsdevel@vger.kernel.org; +Cc: smfrench@gmail.com
In dca692880e887739a669f6c41a80ca68ce2b09fc I see that ".direct_IO = cifs_direct_io" is added only to "cifs_addr_ops" but not to "cifs_addr_ops_smallbuf".
Presuming that the only difference between the two structs is the size of the buffer they operate on (judging by the name), shouldn't ".direct_IO = cifs_direct_io" be added to "cifs_addr_ops_smallbuf" as well?
In a test environment an open(2) using O_DIRECT didn't work (vers=3.0) but when I added ".direct_IO = cifs_direct_io" to "cifs_addr_ops_smallbuf" it worked.
--
Thanos Makatos
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: O_DIRECT not working with vers=3.0
2015-01-22 17:13 O_DIRECT not working with vers=3.0 Thanos Makatos
@ 2015-01-25 0:15 ` Shirish Pargaonkar
0 siblings, 0 replies; 2+ messages in thread
From: Shirish Pargaonkar @ 2015-01-25 0:15 UTC (permalink / raw)
To: Thanos Makatos; +Cc: linux-fsdevel@vger.kernel.org, smfrench@gmail.com
All cifs_direct_io does is return -EINVAL
On Thu, Jan 22, 2015 at 11:13 AM, Thanos Makatos
<thanos.makatos@citrix.com> wrote:
> In dca692880e887739a669f6c41a80ca68ce2b09fc I see that ".direct_IO = cifs_direct_io" is added only to "cifs_addr_ops" but not to "cifs_addr_ops_smallbuf".
> Presuming that the only difference between the two structs is the size of the buffer they operate on (judging by the name), shouldn't ".direct_IO = cifs_direct_io" be added to "cifs_addr_ops_smallbuf" as well?
> In a test environment an open(2) using O_DIRECT didn't work (vers=3.0) but when I added ".direct_IO = cifs_direct_io" to "cifs_addr_ops_smallbuf" it worked.
>
> --
> Thanos Makatos--
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-25 0:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-22 17:13 O_DIRECT not working with vers=3.0 Thanos Makatos
2015-01-25 0:15 ` Shirish Pargaonkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).