From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH] vfs: Don't exchange filenames unconditionally.
Date: Tue, 23 Sep 2014 18:19:06 +0200
Message-ID: <CAELBmZDEEwp1bH9FKBouy+q86u_KLHBth=JvGy_dVLN7bEbmkQ@mail.gmail.com>
References: <1411037700-28966-1-git-send-email-sem@altlinux.org>
	<20140918112206.GA26866@mguzik>
	<20140919182221.0d8c2a92@sem.office.altlinux.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Mateusz Guzik <mguzik@redhat.com>,
	Mikhail Efremov <sem@altlinux.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Miklos Szeredi <mszeredi@suse.cz>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
To: Mikhail Efremov <sem@altlinux.ru>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-ig0-f174.google.com ([209.85.213.174]:47372 "EHLO
	mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754919AbaIWQTI (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 23 Sep 2014 12:19:08 -0400
Received: by mail-ig0-f174.google.com with SMTP id r10so4895630igi.7
        for <linux-fsdevel@vger.kernel.org>; Tue, 23 Sep 2014 09:19:08 -0700 (PDT)
In-Reply-To: <20140919182221.0d8c2a92@sem.office.altlinux.ru>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Sep 19, 2014 at 4:22 PM, Mikhail Efremov <sem@altlinux.ru> wrote:
> On Thu, 18 Sep 2014 13:22:07 +0200 Mateusz Guzik wrote:
>> On Thu, Sep 18, 2014 at 02:55:00PM +0400, Mikhail Efremov wrote:
>> > Only exchange source and destination filenames
>> > if flags contain RENAME_EXCHANGE.

Acked-by: Miklos Szeredi <mszeredi@suse.cz>


>>
>> But names are still exchanged without RENAME_EXCHANGE, provided they are
>> long enough.
>>
>> da1ce0670c14 introduced this behaviour also for short names and this is
>> what you are reverting here.
>>
>> That said, I think the patch is fine as an interim change, but should
>> note facts mentioned above.
>>
>> For more info please see https://lkml.org/lkml/2014/9/7/6
>
> Thanks for pointing out that thread to me, I didn't read it before
> sending the patch.
>
>> I'll be posting a RFC patch for actual problem next week.
>
> I suppose then that no sense to resend this patch right now, I'll just
> wait the proper solution from you.
> Yet this patch can be used as a temporary workaround (as you mentioned
> above) if the proper solution takes longer than expected to implement.

Yes, feel free to resend it to Linus, before 3.17 proper is out.

Also please consider adding:

Cc: stable@vger.kernel.org

Thanks,
Miklos