From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sunil Mushran Subject: Re: kernel BUG at fs/buffer.c:2886! Linux 3.5.0 Date: Thu, 2 Aug 2012 14:08:17 -0700 Message-ID: References: <501313B6.70801@aprogsys.com> <20120730063000.GA4025@dhcp-172-17-9-228.mtv.corp.google.com> <50163B8A.7060509@aprogsys.com> <20120730075333.GC4025@dhcp-172-17-9-228.mtv.corp.google.com> <5016D2C0.6090708@vetienne.net> <501994E8.9070100@aprogsys.com> <501995B7.2030405@vetienne.net> <501A2A7E.10702@aprogsys.com> <501AD4D2.80007@vetienne.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8038371403182168822==" Cc: linux-fsdevel@vger.kernel.org, Mark Fasheh , Alexander Viro , ocfs2-devel@oss.oracle.com To: Vincent ETIENNE Return-path: In-Reply-To: <501AD4D2.80007@vetienne.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com List-Id: linux-fsdevel.vger.kernel.org --===============8038371403182168822== Content-Type: multipart/alternative; boundary=0016e64c1f1481282104c64ecfc3 --0016e64c1f1481282104c64ecfc3 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE wrote: > Hi > > based on current git ( commit 1a9b4993b70fb1884716902774dc9025b457760d ) > and reverting commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 > > commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1 > Author: Al Viro > Date: Thu May 3 10:14:29 2012 -0400 > > ocfs: simplify symlink handling > > and adding the correction from > > > https://oss.oracle.com/git/?p=smushran/linux-2.6.git;a=commit;h=a2118b301104a24381b414bc93371d666fe8d43a > > suppres the fallocate bug > > and lead to no oops. At least immediatly. Will let it run some times > Apply this change and re-run: diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/symlink.c index f1fbb4b..66edce7 100644 --- a/fs/ocfs2/symlink.c +++ b/fs/ocfs2/symlink.c @@ -57,7 +57,7 @@ static int ocfs2_fast_symlink_readpage(struct file *unused, struct page *page) { struct inode *inode = page->mapping->host; - struct buffer_head *bh; + struct buffer_head *bh = NULL; int status = ocfs2_read_inode_block(inode, &bh); struct ocfs2_dinode *fe; const char *link; --0016e64c1f1481282104c64ecfc3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Thu, Aug 2, 2012 at 12:28 PM, Vincent ETIENNE <= ;ve@vetienne.net&g= t; wrote:
Hi

based on current git ( commit 1a9b4993b70fb1884716902774dc9025b457760d ) and =A0reverting commit =A0ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1

commit ea022dfb3c2a4680483b00eb2fecc9fc4f6091d1
Author: Al Viro <viro@zeniv.l= inux.org.uk>
Date: =A0 Thu May 3 10:14:29 2012 -0400

=A0 =A0 ocfs: simplify symlink handling

=A0and =A0adding the correction from

https://o= ss.oracle.com/git/?p=3Dsmushran/linux-2.6.git;a=3Dcommit;h=3Da2118b301104a2= 4381b414bc93371d666fe8d43a

suppres the fallocate bug

and lead to no oops. At least immediatly. Will let it run some times


Apply this change and re-run:<= /div>

diff --git a/fs/ocfs2/symlink.c b/fs/ocfs2/sy= mlink.c
index f1fbb4b..66edce7 100644
--- a/fs/ocfs2/symlink.c
=
+++ b/fs/ocfs2/symlink.c
@@ -57,7 +57,7 @@
=A0stat= ic int ocfs2_fast_symlink_readpage(struct file *unused, struct page *page)<= /div>
=A0{
=A0 =A0 =A0 =A0 struct inode *inode =3D page->mappin= g->host;
- =A0 =A0 =A0 struct buffer_head *bh;
+ =A0= =A0 =A0 struct buffer_head *bh =3D NULL;
=A0 =A0 =A0 =A0 int sta= tus =3D ocfs2_read_inode_block(inode, &bh);
=A0 =A0 =A0 =A0 struct ocfs2_dinode *fe;
=A0 =A0 =A0 =A0 con= st char *link;

--0016e64c1f1481282104c64ecfc3-- --===============8038371403182168822== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel --===============8038371403182168822==--