* [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
@ 2013-05-29 22:29 Bjorn Helgaas
2013-06-13 18:14 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2013-05-29 22:29 UTC (permalink / raw)
To: Alexander Viro
Cc: Jens Axboe, linux-fsdevel, Kent Overstreet, linux-kernel,
Martin K. Petersen
This fixes a copy and paste error introduced by 9f060e2231
("block: Convert integrity to bvec_alloc_bs()").
Found by Coverity (CID 1020654).
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
fs/bio-integrity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
index 8fb4291..45e944f 100644
--- a/fs/bio-integrity.c
+++ b/fs/bio-integrity.c
@@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
mempool_destroy(bs->bio_integrity_pool);
if (bs->bvec_integrity_pool)
- mempool_destroy(bs->bio_integrity_pool);
+ mempool_destroy(bs->bvec_integrity_pool);
}
EXPORT_SYMBOL(bioset_integrity_free);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
2013-05-29 22:29 [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free Bjorn Helgaas
@ 2013-06-13 18:14 ` Bjorn Helgaas
2013-06-13 18:33 ` Kent Overstreet
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2013-06-13 18:14 UTC (permalink / raw)
To: Alexander Viro, Kent Overstreet
Cc: Jens Axboe, linux-fsdevel, linux-kernel@vger.kernel.org,
Martin K. Petersen
On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> This fixes a copy and paste error introduced by 9f060e2231
> ("block: Convert integrity to bvec_alloc_bs()").
>
> Found by Coverity (CID 1020654).
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> fs/bio-integrity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 8fb4291..45e944f 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
> mempool_destroy(bs->bio_integrity_pool);
>
> if (bs->bvec_integrity_pool)
> - mempool_destroy(bs->bio_integrity_pool);
> + mempool_destroy(bs->bvec_integrity_pool);
> }
> EXPORT_SYMBOL(bioset_integrity_free);
Kent, do you want to chime in on this? Looks like an obvious error to
me, but maybe I'm missing something and we should teach Coverity to
shut up about it.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
2013-06-13 18:14 ` Bjorn Helgaas
@ 2013-06-13 18:33 ` Kent Overstreet
2013-09-16 13:40 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Kent Overstreet @ 2013-06-13 18:33 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Alexander Viro, Jens Axboe, linux-fsdevel,
linux-kernel@vger.kernel.org, Martin K. Petersen
On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > This fixes a copy and paste error introduced by 9f060e2231
> > ("block: Convert integrity to bvec_alloc_bs()").
> >
> > Found by Coverity (CID 1020654).
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > fs/bio-integrity.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> > index 8fb4291..45e944f 100644
> > --- a/fs/bio-integrity.c
> > +++ b/fs/bio-integrity.c
> > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
> > mempool_destroy(bs->bio_integrity_pool);
> >
> > if (bs->bvec_integrity_pool)
> > - mempool_destroy(bs->bio_integrity_pool);
> > + mempool_destroy(bs->bvec_integrity_pool);
> > }
> > EXPORT_SYMBOL(bioset_integrity_free);
>
> Kent, do you want to chime in on this? Looks like an obvious error to
> me, but maybe I'm missing something and we should teach Coverity to
> shut up about it.
Sorry - no, this is definitely a bug:
Acked-by: Kent Overstreet <koverstreet@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
2013-06-13 18:33 ` Kent Overstreet
@ 2013-09-16 13:40 ` Bjorn Helgaas
2013-09-16 13:49 ` Bjorn Helgaas
2013-09-17 18:47 ` Jens Axboe
0 siblings, 2 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2013-09-16 13:40 UTC (permalink / raw)
To: Kent Overstreet
Cc: Alexander Viro, Jens Axboe, linux-fsdevel,
linux-kernel@vger.kernel.org, Martin K. Petersen, Gu Zheng
On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet
<koverstreet@google.com> wrote:
> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> > This fixes a copy and paste error introduced by 9f060e2231
>> > ("block: Convert integrity to bvec_alloc_bs()").
>> >
>> > Found by Coverity (CID 1020654).
>> >
>> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> > ---
>> > fs/bio-integrity.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
>> > index 8fb4291..45e944f 100644
>> > --- a/fs/bio-integrity.c
>> > +++ b/fs/bio-integrity.c
>> > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
>> > mempool_destroy(bs->bio_integrity_pool);
>> >
>> > if (bs->bvec_integrity_pool)
>> > - mempool_destroy(bs->bio_integrity_pool);
>> > + mempool_destroy(bs->bvec_integrity_pool);
>> > }
>> > EXPORT_SYMBOL(bioset_integrity_free);
>>
>> Kent, do you want to chime in on this? Looks like an obvious error to
>> me, but maybe I'm missing something and we should teach Coverity to
>> shut up about it.
>
> Sorry - no, this is definitely a bug:
>
> Acked-by: Kent Overstreet <koverstreet@google.com>
>From my v3.12-rc1 reminder list: what's going on with this patch?
It's been acked, Gu asked whether he could include it in some
patchset, I see a Sep 11 2013 patch from Gu upstream already
(bc5c8f078), but this patch (from May 29 2013) still hasn't gone
anywhere. Why is this so hard?
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
2013-09-16 13:40 ` Bjorn Helgaas
@ 2013-09-16 13:49 ` Bjorn Helgaas
2013-09-17 18:47 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2013-09-16 13:49 UTC (permalink / raw)
To: Kent Overstreet
Cc: Alexander Viro, Jens Axboe, linux-fsdevel,
linux-kernel@vger.kernel.org, Martin K. Petersen, Gu Zheng
[update Kent's email address]
On Mon, Sep 16, 2013 at 7:40 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet
> <koverstreet@google.com> wrote:
>> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
>>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>> > This fixes a copy and paste error introduced by 9f060e2231
>>> > ("block: Convert integrity to bvec_alloc_bs()").
>>> >
>>> > Found by Coverity (CID 1020654).
>>> >
>>> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>>> > ---
>>> > fs/bio-integrity.c | 2 +-
>>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>> >
>>> > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
>>> > index 8fb4291..45e944f 100644
>>> > --- a/fs/bio-integrity.c
>>> > +++ b/fs/bio-integrity.c
>>> > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
>>> > mempool_destroy(bs->bio_integrity_pool);
>>> >
>>> > if (bs->bvec_integrity_pool)
>>> > - mempool_destroy(bs->bio_integrity_pool);
>>> > + mempool_destroy(bs->bvec_integrity_pool);
>>> > }
>>> > EXPORT_SYMBOL(bioset_integrity_free);
>>>
>>> Kent, do you want to chime in on this? Looks like an obvious error to
>>> me, but maybe I'm missing something and we should teach Coverity to
>>> shut up about it.
>>
>> Sorry - no, this is definitely a bug:
>>
>> Acked-by: Kent Overstreet <koverstreet@google.com>
>
> From my v3.12-rc1 reminder list: what's going on with this patch?
>
> It's been acked, Gu asked whether he could include it in some
> patchset, I see a Sep 11 2013 patch from Gu upstream already
> (bc5c8f078), but this patch (from May 29 2013) still hasn't gone
> anywhere. Why is this so hard?
>
> Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
2013-09-16 13:40 ` Bjorn Helgaas
2013-09-16 13:49 ` Bjorn Helgaas
@ 2013-09-17 18:47 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2013-09-17 18:47 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Kent Overstreet, Alexander Viro, linux-fsdevel,
linux-kernel@vger.kernel.org, Martin K. Petersen, Gu Zheng
On 09/16/2013 07:40 AM, Bjorn Helgaas wrote:
> On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet
> <koverstreet@google.com> wrote:
>> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
>>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>>> This fixes a copy and paste error introduced by 9f060e2231
>>>> ("block: Convert integrity to bvec_alloc_bs()").
>>>>
>>>> Found by Coverity (CID 1020654).
>>>>
>>>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>>>> ---
>>>> fs/bio-integrity.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
>>>> index 8fb4291..45e944f 100644
>>>> --- a/fs/bio-integrity.c
>>>> +++ b/fs/bio-integrity.c
>>>> @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
>>>> mempool_destroy(bs->bio_integrity_pool);
>>>>
>>>> if (bs->bvec_integrity_pool)
>>>> - mempool_destroy(bs->bio_integrity_pool);
>>>> + mempool_destroy(bs->bvec_integrity_pool);
>>>> }
>>>> EXPORT_SYMBOL(bioset_integrity_free);
>>>
>>> Kent, do you want to chime in on this? Looks like an obvious error to
>>> me, but maybe I'm missing something and we should teach Coverity to
>>> shut up about it.
>>
>> Sorry - no, this is definitely a bug:
>>
>> Acked-by: Kent Overstreet <koverstreet@google.com>
>
> From my v3.12-rc1 reminder list: what's going on with this patch?
>
> It's been acked, Gu asked whether he could include it in some
> patchset, I see a Sep 11 2013 patch from Gu upstream already
> (bc5c8f078), but this patch (from May 29 2013) still hasn't gone
> anywhere. Why is this so hard?
Queued up.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-17 18:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-29 22:29 [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free Bjorn Helgaas
2013-06-13 18:14 ` Bjorn Helgaas
2013-06-13 18:33 ` Kent Overstreet
2013-09-16 13:40 ` Bjorn Helgaas
2013-09-16 13:49 ` Bjorn Helgaas
2013-09-17 18:47 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).