From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3014CC43218 for ; Thu, 25 Apr 2019 21:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4075C206BF for ; Thu, 25 Apr 2019 21:37:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="edaqH3pX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731262AbfDYVhY (ORCPT ); Thu, 25 Apr 2019 17:37:24 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:35344 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbfDYVhX (ORCPT ); Thu, 25 Apr 2019 17:37:23 -0400 Received: by mail-oi1-f193.google.com with SMTP id w197so1319962oia.2 for ; Thu, 25 Apr 2019 14:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RGUgSN/1MuaT0sEkx4/PHOTF00tRdaquGMmXyWySbhU=; b=edaqH3pXiEXpUmitUuXFWk+YsMBzEo/wRbafWYnIriVAmTmf/hZDKMWYzoNNH8oP+R bC+L8TVKnbipZ4SOAofD8rBq1yG2z/wZSk50Q9P9Yr1DrvXxI8TDrkMs++R6/OonwdO9 74izLWERfec1GdE1xNOK3wfairC7wD1IwRBd6Vw26OFYxJBjlOnzqt22cTdMjpIcf37o S+DIWo9AGr3T1ABXIchf3VePE0iuwngS8Nc9fclUuQwhkZbwhtqheo4mssjcPl+ztLbU 5EcZE3o5HkugWFjrsIq8GzxRoyNKX7lmKmESdN8Ehi+ur56DpKR30L5vQHX/a3wC1u6P D1mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RGUgSN/1MuaT0sEkx4/PHOTF00tRdaquGMmXyWySbhU=; b=XVDFNugdF4KcZOgkp6iJUhM+y4fPPLB1wmzdXME47dPoKRiyUItw2c2J8B7I4+DJR6 HzUx4kzWU4G2e+ckIycr9XpA4UFOwvEDq8PyxvqsYZsJNbHrmJzz9I3Uz4m2vWHZGg7k RfcCOikv2bt9sa/xPmm10kRfU9dMmy3WPBHQBD4nCdguicTUbIkN3YIGwp8MU7f2dMcV wPGYxJCnZ8jBk88C3CyHRG3eeHmZsZtZkMimJw4e7K2Wk9HhwXmKUqZnF7NdPHijuIOv cPQ9yh06CFnsGNX4vDbSCGb4JIcGRZlR3ekRz0CwiekTuzjMkeyyZoH20wD/S17YQN8m xwdA== X-Gm-Message-State: APjAAAUeIlTsZHQFc5yG8ZevzXC64s85ynEbbntExIxO0hYZZfCMbPr/ 1stgXJ4UQZb80HtVh26dHJ1pYt5d8Nbc3mUR2S4uxw== X-Google-Smtp-Source: APXvYqxNu7qXytlEj2RXMttlfz2eUzqPPX+vSS3fXl27uou+1aPJ+bT6BWbWn9cn6mf63VhaXUUe6QTIeJnzpNOZ4Z8= X-Received: by 2002:aca:4586:: with SMTP id s128mr4538562oia.148.1556228242522; Thu, 25 Apr 2019 14:37:22 -0700 (PDT) MIME-Version: 1.0 References: <20190404220652.19765-1-brendanhiggins@google.com> <20190404220652.19765-15-brendanhiggins@google.com> <20190424185813.xabwr4lt6aunvpsd@gabell> In-Reply-To: <20190424185813.xabwr4lt6aunvpsd@gabell> From: Brendan Higgins Date: Thu, 25 Apr 2019 14:37:11 -0700 Message-ID: Subject: Re: [PATCH v1 14/17] Documentation: kunit: add documentation for KUnit To: Masayoshi Mizuma Cc: Jonathan Corbet , Frank Rowand , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , shuah@kernel.org, yamada.masahiro@socionext.com, Petr Mladek , linux-doc@vger.kernel.org, Amir Goldstein , dri-devel , Sasha Levin , linux-kselftest@vger.kernel.org, linux-nvdimm , Kevin Hilman , Knut Omang , Felix Guo , wfg@linux.intel.com, Joel Stanley , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild@vger.kernel.org, "Bird, Timothy" , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Richard Weinberger , Greg KH , Linux Kernel Mailing List , Daniel Vetter , Michael Ellerman , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 24, 2019 at 11:58 AM Masayoshi Mizuma wrote: > > Hi Brendan, > > KUNIT_ASSERT_NOT_ERR_OR_NULL() should be replaced to > KUNIT_EXPECT_NOT_ERR_OR_NULL(), right? Generally speaking, no. There may be places that I have used it improperly, but I think it is generally okay to use. If you are refering to the discussion with Frank and Stephen in RFC v4, my take was that the resolution was that there were some things I needed to fix in its implementation, but it is conceptually okay, and that Frank doesn't want me to use it in drivers/of/unittest.c. Consequently, I fixed the implementation issues that Frank and Stephen pointed out, and I am holding off on drivers/of/unittest.c for this patchset. The usage in this file should be fine. > > On Thu, Apr 04, 2019 at 03:06:49PM -0700, Brendan Higgins wrote: > > Add documentation for KUnit, the Linux kernel unit testing framework. > > - Add intro and usage guide for KUnit > > - Add API reference > > > > Signed-off-by: Felix Guo > > Signed-off-by: Brendan Higgins > > --- > > Cheers