From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56797C43219 for ; Fri, 3 May 2019 00:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25D5C2087F for ; Fri, 3 May 2019 00:41:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FJIAYLW9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726487AbfECAlW (ORCPT ); Thu, 2 May 2019 20:41:22 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:39210 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726475AbfECAlV (ORCPT ); Thu, 2 May 2019 20:41:21 -0400 Received: by mail-oi1-f193.google.com with SMTP id w130so2800583oie.6 for ; Thu, 02 May 2019 17:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i/LGIUMFfkHhxCSDT3fm51UOA28cPrGRFTawiLz9qdU=; b=FJIAYLW9LNf9oanARKl7TfF4hN+5D95QZaw548QJynu0CjT8BCwlpKeraO6t9YYkOs GtNX3/gAG5EXPOJwbqEw8XIrwSSwlKCrob0M1UGIcbcgu72bFgtpR14EttoAsQY2aDgu R3g2UNQXhcb3FGDMQxi+sYsTRkYHs3qzvEqqHMGSEtbYKM2QA4nxdIkJahuLnsBoO2+c TGr8njZSgd2pD66c4pynpYDwYtRx3F05qDNXkbRYRi3lANeuXFpYdvOTMjhMHRrrhF8P 3i1MCfzjUMz11YJpZRIR9WsEPFVnmwGmtj8MUe4JYxQcAMMsvhz5BhNLX+0hNU5ukE4d 83hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i/LGIUMFfkHhxCSDT3fm51UOA28cPrGRFTawiLz9qdU=; b=jU33/NYukMUaDaUxFPn9SyeWkw/acGlImteDIwTOGO1SHIKLieCXuVzlL9ieKtdYoG 0b+66MWuGqWW9I8Zk6gtySb5BiOL14CWmd8y+hsFh0q4e9t24P/1Wizr9S8ZrQsJUIXz Xu8DOC4/t8NlH7FUYutB5N+jGiJY+Rn5LatZPidbkHk6ZGLa3DCCnHrZnhb4UjDuMJ9w tMwOTjuqLjesseGWw5WO7TO3jomoy4d/QDCetgBXiZmL5v1oo/ivn8rWazACMvXe1Qmp kzwuD0V0oz7P1oWFlgBF77mlpaUSXnCzSbE4ByHgGuRZzaxFY8rI3fpoLZAFCJS8x+UX 1hvg== X-Gm-Message-State: APjAAAV7jyncWTCtgiDrsc+stHcOVg1o1Zed54PJOe3Lqo5NDbDtvv56 qUYWPTaXpPomcLCyRLKBYQqGm2p9MLaHfMGd/pXrpw== X-Google-Smtp-Source: APXvYqx+IeNo/M2uU5es7ZAJsOSGR6b01vZ0dEQaWTEj9cNFRVwEHLuSMfXDE/OIHXARFXXWqbF1LQIlh8BGLZyE6Eo= X-Received: by 2002:aca:4586:: with SMTP id s128mr4126147oia.148.1556844080319; Thu, 02 May 2019 17:41:20 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190502105053.GA12416@kroah.com> <20190502110513.GF12416@kroah.com> In-Reply-To: <20190502110513.GF12416@kroah.com> From: Brendan Higgins Date: Thu, 2 May 2019 17:41:08 -0700 Message-ID: Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework To: Greg KH Cc: Frank Rowand , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , shuah@kernel.org, devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, May 2, 2019 at 4:05 AM Greg KH wrote: > > On Thu, May 02, 2019 at 12:50:53PM +0200, Greg KH wrote: > > On Wed, May 01, 2019 at 04:01:09PM -0700, Brendan Higgins wrote: > > > ## TLDR > > > > > > I rebased the last patchset on 5.1-rc7 in hopes that we can get this in > > > 5.2. > > > > That might be rushing it, normally trees are already closed now for > > 5.2-rc1 if 5.1-final comes out this Sunday. > > > > > Shuah, I think you, Greg KH, and myself talked off thread, and we agreed > > > we would merge through your tree when the time came? Am I remembering > > > correctly? > > > > No objection from me. > > > > Let me go review the latest round of patches now. > > Overall, looks good to me, and provides a framework we can build on. > I'm a bit annoyed at the reliance on uml at the moment, but we can work > on that in the future :) Eh, I mostly fixed that. I removed the KUnit framework's reliance on UML i.e. the actual tests now run on any architecture. The only UML dependent bit is the KUnit wrapper scripts, which could be made to work to support other architectures pretty trivially. The only limitation here is that it would be dependent on the actual workflow you are using. In anycase, if you are comfortable reading the results in the kernel logs, then there is no dependence on UML. (I should probably provide some documentation on that...) > > Thanks for sticking with this, now the real work begins... I don't doubt it. > > Reviewed-by: Greg Kroah-Hartman Does this cover all the patches in this set? Thanks!