From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 272D5C5517A for ; Fri, 30 Oct 2020 03:03:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C57E5206ED for ; Fri, 30 Oct 2020 03:03:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AybJN8x6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726231AbgJ3DDM (ORCPT ); Thu, 29 Oct 2020 23:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbgJ3DDG (ORCPT ); Thu, 29 Oct 2020 23:03:06 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA649C0613D6 for ; Thu, 29 Oct 2020 20:03:05 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id 126so5988373lfi.8 for ; Thu, 29 Oct 2020 20:03:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qetmnWNVsQksjakl8dXjUkaIoxiVzA6keFiGM2ap5AY=; b=AybJN8x6VEeLGCBEBx81sKm96EvpYJ8EOMN+ehVaa6kd1osmMtolGYpNiB+P0jXeBh JKcVuff4V9jHq7LjenAGN4DP3DoekAwTcbRvi61IrciA2+MhWuRptX/cfrMWp2rh9BUL WfSbatM3Au8j1fzzyV3HW0euf/Cis4dc9BCinMZ0G63d+e5Ck9hSrP0cmSaexwCaLIK9 WfxfJxdjfpqlNROWMWoWk7G1JjCULiMI0/IvyTkN/Ok5//vRUceaGL6seL1jFZ9UpPZ/ 9JxTapyOGkoyBE2PhKDWHY3u4CBkCKKhDihE7xCjbPZeuq44+LhTw7iHPhvtRuHFZqre rTQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qetmnWNVsQksjakl8dXjUkaIoxiVzA6keFiGM2ap5AY=; b=i4446oYfa963q0h9CM1JAcO/R+x/33fLZf2Ys91pGH4IUPEKuhFUYxd0iYffONoi8d 4ubo5fMvcnFBTcIyrcI/6SE7N7ZMkkD+SiDh+UQjGgTO+d3klMELfhprT6RlzgCkp1hl Xg3y66zxo2iv9gvoxH+lygjJXhMO2Bw7zCYO8v1AcOCOTu/lWQOujRon/+icbxmHNAjh xNKq14km5mKhJwzDgJrLWeKLtBUW3pp7iWVjVevzpg5IDmZh/sLgYiQgUrqGwDB01MLb UHxJjwvbiZCa9hmlGtGs24lcBUhtXrkSc87bIft9/7DszH9AC19rabkzKPNcNouYPZRS n2og== X-Gm-Message-State: AOAM530HxDsbCbFGdNOy+a4YUSnJ7v2TpdJrQk+5jqDhkXrSpfsJbETF 0KandY01q9KURTOOSEfLWwh5K1Zp4s8LrJUdqDRDAA== X-Google-Smtp-Source: ABdhPJzYTNXH60XmJevS1nU77QTkbnJdxDa2BUkj+JK2GK03XFm5dsruLADHPeQtCXNc8JlilkKNtelCRS8CC6e1sv0= X-Received: by 2002:a19:c357:: with SMTP id t84mr39422lff.34.1604026983869; Thu, 29 Oct 2020 20:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20201027200358.557003-1-mic@digikod.net> <20201027200358.557003-2-mic@digikod.net> In-Reply-To: From: Jann Horn Date: Fri, 30 Oct 2020 04:02:37 +0100 Message-ID: Subject: Re: [PATCH v22 01/12] landlock: Add object management To: =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= Cc: James Morris , "Serge E . Hallyn" , Al Viro , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , Jeff Dike , Jonathan Corbet , Kees Cook , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , Kernel Hardening , Linux API , linux-arch , "open list:DOCUMENTATION" , linux-fsdevel , kernel list , "open list:KERNEL SELFTEST FRAMEWORK" , linux-security-module , "the arch/x86 maintainers" , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Oct 29, 2020 at 10:30 AM Micka=C3=ABl Sala=C3=BCn = wrote: > On 29/10/2020 02:05, Jann Horn wrote: > > On Tue, Oct 27, 2020 at 9:04 PM Micka=C3=ABl Sala=C3=BCn wrote: > >> A Landlock object enables to identify a kernel object (e.g. an inode). > >> A Landlock rule is a set of access rights allowed on an object. Rules > >> are grouped in rulesets that may be tied to a set of processes (i.e. > >> subjects) to enforce a scoped access-control (i.e. a domain). [...] > >> diff --git a/security/landlock/object.c b/security/landlock/object.c > > [...] > >> +void landlock_put_object(struct landlock_object *const object) > >> +{ > >> + /* > >> + * The call to @object->underops->release(object) might sleep = e.g., > > > > s/ e.g.,/, e.g./ > > I indeed prefer the comma preceding the "e.g.", but it seems that there > is a difference between UK english and US english: > https://english.stackexchange.com/questions/16172/should-i-always-use-a-c= omma-after-e-g-or-i-e > Looking at the kernel documentation makes it clear: > $ git grep -F 'e.g. ' | wc -l > 1179 > $ git grep -F 'e.g., ' | wc -l > 160 > > I'll apply your fix in the whole patch series. Ooh, sorry. I didn't realize that that's valid in UK English...