From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B37C77B7A for ; Thu, 20 Apr 2023 18:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbjDTSRg (ORCPT ); Thu, 20 Apr 2023 14:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231376AbjDTSRd (ORCPT ); Thu, 20 Apr 2023 14:17:33 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4039C4208 for ; Thu, 20 Apr 2023 11:17:28 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5051abd03a7so1067442a12.2 for ; Thu, 20 Apr 2023 11:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682014646; x=1684606646; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NzocEjSvrz85xEKE5MWcbLv/boctI2KKwjYq7LHKyz4=; b=S2ctvNqMIvOioIiHZwWJbdVQexXnEJfkUsuEM04PMllQQAq/sE8IIOM0eDrdZYpgEJ xYvvOg1SKcnNSA1ne7Anfer1mqpLaVnAcBhSp+ghH7N/HQ8XDHIwRGXapE+PvHn+SSWd 4oiG653PvBxwj57BngCB9Qxok+vr5fsaip9T4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682014646; x=1684606646; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NzocEjSvrz85xEKE5MWcbLv/boctI2KKwjYq7LHKyz4=; b=CmSTgH2wINGzWPdR833ISbYwRvqlCy+5SqGLCSGQTd/37x81yhtmu64K7bAPxbvFP6 44IU0Uz5kObpDCFJC02lPcSthneN7fFnJDbEQ7xeeGPaRxS0c5Z2Ad8kCkd7W9Gnddq6 WYbKFyA04M/YKoENhZfqJc4kK7/XbeCtqhi6qMoaRx5x2nouRr0WsgWbPuRLnVRNjnkm rCTCaVMsCXJoRWwoPWQVUlSeL8yi+wEbfq6Bn8Dgs4Ru/kNnHMLa5NYniT7+E0jpzSuf G8mgQ9vzrJkHctxGyY3TTMQiPePoRHDm33a6/Slt7j6LiNcgC8uem1kau/epanubLEI1 WQBg== X-Gm-Message-State: AAQBX9e3mPY0k7tZWKchYF7UngWucCOY/ShD6gWDL535oQS7tqiE92c6 LGPQvzCNrvCSw4oPYbjEG8hId9Jpi6/DfkCKGnupmg== X-Google-Smtp-Source: AKy350bUbgX+6BAetL35DQRlN+iICSaVw+B/jOXdxmTlFH/Y/a2lnx/qR3DkR104XRtbf49FVqzsbMMtZaekb6roEd8= X-Received: by 2002:aa7:c592:0:b0:508:3f08:ea0f with SMTP id g18-20020aa7c592000000b005083f08ea0fmr2514672edq.28.1682014646672; Thu, 20 Apr 2023 11:17:26 -0700 (PDT) MIME-Version: 1.0 References: <20230420172807.323150-1-sarthakkukreti@chromium.org> In-Reply-To: <20230420172807.323150-1-sarthakkukreti@chromium.org> From: Sarthak Kukreti Date: Thu, 20 Apr 2023 11:17:15 -0700 Message-ID: Subject: Re: [PATCH v5-fix 1/5] block: Don't invalidate pagecache for invalid falloc modes To: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Stefan Hajnoczi , Alasdair Kergon , Mike Snitzer , Christoph Hellwig , Brian Foster , "Theodore Ts'o" , Andreas Dilger , Bart Van Assche , Daniil Lunev , "Darrick J. Wong" , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org This patch had a slight typo; fixed in the most recent patch. - Sarthak On Thu, Apr 20, 2023 at 10:28=E2=80=AFAM Sarthak Kukreti wrote: > > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devi= ces") > Cc: stable@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti > --- > block/fops.c | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/block/fops.c b/block/fops.c > index d2e6be4e3d1c..20b1eddcbe25 100644 > --- a/block/fops.c > +++ b/block/fops.c > @@ -648,24 +648,35 @@ static long blkdev_fallocate(struct file *file, int= mode, loff_t start, > > filemap_invalidate_lock(inode->i_mapping); > > - /* Invalidate the page cache, including dirty pages. */ > - error =3D truncate_bdev_range(bdev, file->f_mode, start, end); > - if (error) > - goto fail; > - > + /* > + * Invalidate the page cache, including dirty pages, for valid > + * de-allocate mode calls to fallocate(). > + */ > switch (mode) { > case FALLOC_FL_ZERO_RANGE: > case FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE: > + error =3D truncate_bdev_range(bdev, file->f_mode, start, = end); > + if (error) > + goto fail; > + > error =3D blkdev_issue_zeroout(bdev, start >> SECTOR_SHIF= T, > len >> SECTOR_SHIFT, GFP_KER= NEL, > BLKDEV_ZERO_NOUNMAP); > break; > case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE: > + error =3D truncate_bdev_range(bdev, file->f_mode, start, = end); > + if (error) > + goto fail; > + > error =3D blkdev_issue_zeroout(bdev, start >> SECTOR_SHIF= T, > len >> SECTOR_SHIFT, GFP_KER= NEL, > BLKDEV_ZERO_NOFALLBACK); > break; > case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HI= DE_STALE: > + error =3D truncate_bdev_range(bdev, file->f_mode, start, = end); > + if (!error) > + goto fail; > + > error =3D blkdev_issue_discard(bdev, start >> SECTOR_SHIF= T, > len >> SECTOR_SHIFT, GFP_KER= NEL); > break; > -- > 2.40.0.396.gfff15efe05-goog >