From: Mateusz Guzik <mjguzik@gmail.com>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alejandro Colomar <alx@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Huacai Chen <chenhuacai@loongson.cn>,
Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Icenowy Zheng <uwu@icenowy.me>,
linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] vfs: Shortcut AT_EMPTY_PATH early for statx, and add AT_NO_PATH for statx and fstatat
Date: Tue, 25 Jun 2024 12:52:39 +0200 [thread overview]
Message-ID: <CAGudoHEDKvP926Q6tX1Te_WW9_OTLUoDRTO3nCO3LHo6HJyLpQ@mail.gmail.com> (raw)
In-Reply-To: <30a5fe67500c40a4d5f9516e9b549ec796faac74.camel@xry111.site>
On Tue, Jun 25, 2024 at 12:51 PM Xi Ruoyao <xry111@xry111.site> wrote:
>
> On Tue, 2024-06-25 at 10:50 +0200, Christian Brauner wrote:
> > No, let's not waste AT_* flag space in fear of some hypothetical
> > breakage. Let's try it cleanly first and make AT_EMPTY_PATH work with
> > NULL paths.
> >
> > Note, I started working on this (checks ...) 30th April but then some
> > other work came up and I never got back to it (Sorry, Linus). I pushed
> > the branch to #vfs.empty.path now. The top three commits was what I had
> > started doing.
> >
> > It was based on a new vfs_empty_path() helper so we could reuse it for
> > other system calls as well.
>
> If I understand correctly, I should submit a patch against
> vfs.empty.path making statx(fd, NULL, AT_EMPTY_PATH) work then?
>
I just sorted this out, will be sending a patchset shortly.
--
Mateusz Guzik <mjguzik gmail.com>
prev parent reply other threads:[~2024-06-25 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 8:50 [PATCH v2] vfs: Shortcut AT_EMPTY_PATH early for statx, and add AT_NO_PATH for statx and fstatat Xi Ruoyao
2024-06-24 8:54 ` Xi Ruoyao
2024-06-24 9:04 ` Mateusz Guzik
2024-06-24 12:19 ` Xi Ruoyao
2024-06-24 12:28 ` Mateusz Guzik
2024-06-25 8:50 ` Christian Brauner
2024-06-25 10:51 ` Xi Ruoyao
2024-06-25 10:52 ` Mateusz Guzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGudoHEDKvP926Q6tX1Te_WW9_OTLUoDRTO3nCO3LHo6HJyLpQ@mail.gmail.com \
--to=mjguzik@gmail.com \
--cc=alx@kernel.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jack@suse.cz \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=uwu@icenowy.me \
--cc=viro@zeniv.linux.org.uk \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).