From: Mateusz Guzik <mjguzik@gmail.com>
To: Xi Ruoyao <xry111@xry111.site>
Cc: brauner@kernel.org, Miao Wang <shankerwangmiao@gmail.com>,
viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
io-uring@vger.kernel.org, axboe@kernel.dk,
torvalds@linux-foundation.org, loongarch@lists.linux.dev
Subject: Re: [PATCH v3] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...)
Date: Wed, 25 Sep 2024 17:56:40 +0200 [thread overview]
Message-ID: <CAGudoHFrTWktBYQjrQMJbVZvWLPD3A51YsOMOJqAtpdruSkGsQ@mail.gmail.com> (raw)
In-Reply-To: <6afb4e1e2bad540dcb4790170c42f38a95d369bb.camel@xry111.site>
On Wed, Sep 25, 2024 at 4:30 PM Xi Ruoyao <xry111@xry111.site> wrote:
> There's a special case, AT_FDCWD + NULL + AT_EMPTY_PATH, still resulting
> EFAULT, while AT_FDCWD + "" + AT_EMPTY_PATH is OK (returning the stat of
> current directory).
>
> I know allowing NULL with AT_FDCWD won't produce any performance gain,
> but it seems the difference would make the document of the API more
> nasty.
>
> So is it acceptable to make the kernel "hide" this difference, i.e.
> accept AT_FDCWD + NULL + AT_EMPTY_PATH as-is AT_FDCWD + "" +
> AT_EMPTY_PATH?
>
huh, that indeed makes sense to add. kind of weird this was not sorted
out at the time, but i'm not going to pointer a finger at myself :) so
ACK from me as far as the idea goes
I presume you can do the honors? :)
--
Mateusz Guzik <mjguzik gmail.com>
next prev parent reply other threads:[~2024-09-25 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 15:18 [PATCH v3] vfs: support statx(..., NULL, AT_EMPTY_PATH, ...) Mateusz Guzik
2024-06-26 2:59 ` Xi Ruoyao
2024-06-26 13:39 ` Mateusz Guzik
2024-06-26 14:35 ` Christian Brauner
2024-06-26 15:02 ` Jens Axboe
2024-06-26 3:15 ` Xi Ruoyao
2024-06-26 13:05 ` Christian Brauner
2024-09-25 14:30 ` Xi Ruoyao
2024-09-25 15:56 ` Mateusz Guzik [this message]
2024-09-26 13:02 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGudoHFrTWktBYQjrQMJbVZvWLPD3A51YsOMOJqAtpdruSkGsQ@mail.gmail.com \
--to=mjguzik@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=shankerwangmiao@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).