From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D7FFC433FE for ; Thu, 21 Oct 2021 23:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8EFD6135F for ; Thu, 21 Oct 2021 23:16:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232326AbhJUXSX (ORCPT ); Thu, 21 Oct 2021 19:18:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232410AbhJUXST (ORCPT ); Thu, 21 Oct 2021 19:18:19 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D14C061764; Thu, 21 Oct 2021 16:16:02 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id j21so5466173lfe.0; Thu, 21 Oct 2021 16:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NGd3ZBTVw8WerW8TiXkapULoiLMOJ6XxJFj9gFvuuSU=; b=b2s6FHWu+usXqQrC6G5oR1QXzV421vmzu616cj0TNoasagpoWnKOEKbYxv6lwcqPeI 3rORErL7fa/RFd0y2Vi9iFsS945DYpKaBv5nii1hrDWFRTJAvwghzmPtEJj+WMAEM17L /O3Sh1kCF4mjJgVQs5ZVXMKHMXWjelDAnQuriR3P4qbXBgow863UHNut4GWOwsAcq3R8 LkWsfmC9oiosn2tFEKgiUpbhG4Nj1FZGqH8d5l/mF+MDgVDszmLDzMmBdqz5dfZydR6W CwiG1vdp59S9FmUIPQ76gL5GOhXou9LfjHasOMDZ9f3WorvSSWSHDMjI2c/fnqLqoXEM 8naQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NGd3ZBTVw8WerW8TiXkapULoiLMOJ6XxJFj9gFvuuSU=; b=q6clXKjd+1N1hCp8jdTnitbz4y6OqwHd6HBKO1twKQBtkPyjOj5d1VWB8jMvbF24QV NUERDdfV4FL47Onz74r81zk7KzHRUgJ/JfkAiqisboBIQQcyt9CSrpzIpfaLppUSm+25 9sM0TeTbuJew5BJt4UTA15PvAk8i1hWnDGX6K36IuM0PSnmJQlwNmew9sQtJgj1PUGaz CQidLadGxjEBFfWU/Y9Qi3f0UBAWBnzSMF4/0Y94JCFSYik+Vgl3wjvdeaKu2nVMv6O3 es0YZbqgp91IDh9PEoPGJEJs4C8R1C2K70RYiVjLYe3TqY0qNCq8ss1+HOcS4MMRA3WU geMA== X-Gm-Message-State: AOAM531bVULI7mss9ONV7EPTcclTb9W3rcDJ4YTb2l29PwsBvtMCfS/y 7K6X4gT59lmlL79znnwMxGZHK2GIbPb/2wMF72A= X-Google-Smtp-Source: ABdhPJwZpcQ1KdeVcaHk764w6WspHm/7cDejlBv/A5lS6M8tifVYkMndPvZos9ePSqOr5Sy9U5NwiVeDSIz4sIygGiM= X-Received: by 2002:a05:6512:3763:: with SMTP id z3mr8185733lft.601.1634858160588; Thu, 21 Oct 2021 16:16:00 -0700 (PDT) MIME-Version: 1.0 References: <163456861570.2614702.14754548462706508617.stgit@warthog.procyon.org.uk> In-Reply-To: From: Steve French Date: Thu, 21 Oct 2021 18:15:49 -0500 Message-ID: Subject: Re: [PATCH 00/67] fscache: Rewrite index API and management system To: Omar Sandoval Cc: David Howells , linux-cachefs@redhat.com, ceph-devel , linux-afs@lists.infradead.org, Anna Schumaker , linux-nfs , Kent Overstreet , linux-mm , Matthew Wilcox , linux-fsdevel , Dave Wysochanski , Marc Dionne , Trond Myklebust , Shyam Prasad N , Eric Van Hensbergen , v9fs-developer@lists.sourceforge.net, CIFS , Latchesar Ionkov , Jeff Layton , Steve French , Al Viro , Dominique Martinet , Ilya Dryomov , Trond Myklebust , Jeff Layton , Linus Torvalds , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Oct 21, 2021 at 5:21 PM Omar Sandoval wrote: > > On Mon, Oct 18, 2021 at 03:50:15PM +0100, David Howells wrote: > However, with the advent of the tmpfile capacity in the VFS, an opportunity > arises to do invalidation much more easily, without having to wait for I/O > that's actually in progress: Cachefiles can simply cut over its file > pointer for the backing object attached to a cookie and abandon the > in-progress I/O, dismissing it upon completion. Have changes been made to O_TMPFILE? It is problematic for network filesystems because it is not an atomic operation, and would be great if it were possible to create a tmpfile and open it atomically (at the file system level). Currently it results in creating a tmpfile (which results in opencreate then close) immediately followed by reopening the tmpfile which is somewhat counter to the whole idea of a tmpfile (ie that it is deleted when closed) since the syscall results in two opens ie open(create)/close/open/close -- Thanks, Steve