From: JaeJoon Jung <rgbi3307@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Sasha Levin <levinsasha928@gmail.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
maple-tree@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] lib/htree: Add locking interface to new Hash Tree
Date: Thu, 8 Aug 2024 07:13:56 +0900 [thread overview]
Message-ID: <CAHOvCC4bYNkoku_HWDadEBNfWNJGFkVVmz5XcAeMe0EAT_5HEw@mail.gmail.com> (raw)
In-Reply-To: <ZrLuelS7yx92SKk7@casper.infradead.org>
Hello, Matthew
Thank you so much for the advice above.
I've been analyzing your XArray for years now and it's helped me a lot.
Finding an index through bit shifting in XArray seems to very ingenious way.
If you have time, Could you talk a bit more on the dcache advice you gave above?
My guess is that it has to do with the memory cache associated with the MMU.
On Wed, 7 Aug 2024 at 12:48, Matthew Wilcox <willy@infradead.org> wrote:
>
> On Wed, Aug 07, 2024 at 09:21:12AM +0900, JaeJoon Jung wrote:
> > Performance comparison when the number of indexes(nr) is 1M stored:
> > The numeric unit is cycles as calculated by get_cycles().
> >
> > Performance store find erase
> > ---------------------------------------------
> > XArray 4 6 14
> >
> > Maple Tree 7 8 23
> >
> > Hash Tree 5 3 12
> > ---------------------------------------------
> >
> > Please check again considering the above.
>
> I would suggest that you find something to apply your new data structure
> to. My suggestion would be the dcache, as I did with rosebush. That let
> us find out that rosebush was not good for that application, and so I
> abandoned work on it.
next prev parent reply other threads:[~2024-08-07 22:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:01 [PATCH v2 1/2] lib/htree: Add locking interface to new Hash Tree JaeJoon Jung
2024-08-05 18:33 ` Greg Kroah-Hartman
2024-08-06 7:07 ` Greg Kroah-Hartman
2024-08-06 7:32 ` JaeJoon Jung
2024-08-06 7:38 ` Greg Kroah-Hartman
2024-08-07 0:21 ` JaeJoon Jung
2024-08-07 1:10 ` Pedro Falcato
2024-08-07 1:42 ` lsahn
2024-08-07 2:24 ` JaeJoon Jung
2024-08-07 3:48 ` Matthew Wilcox
2024-08-07 22:13 ` JaeJoon Jung [this message]
2024-08-07 1:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHOvCC4bYNkoku_HWDadEBNfWNJGFkVVmz5XcAeMe0EAT_5HEw@mail.gmail.com \
--to=rgbi3307@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).