linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] fs: Fix overflow in block_page_mkwrite
Date: Wed, 18 Dec 2019 13:51:52 +0100	[thread overview]
Message-ID: <CAHc6FU4SodZg1XTZ-BRjTrYiWVdGz4ZfbzZQtevv=TCuHwxbJw@mail.gmail.com> (raw)
In-Reply-To: <20191218124346.GC19387@quack2.suse.cz>

Hi Jan,

On Wed, Dec 18, 2019 at 1:43 PM Jan Kara <jack@suse.cz> wrote:
> On Wed 06-11-19 20:02:39, Andreas Gruenbacher wrote:
> > On architectures where ssize_t is wider than pgoff_t, the expression
> > ((page->index + 1) << PAGE_SHIFT) can overflow.  Rewrite to use the page
> > offset, which we already compute here anyway.
> >
> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>
> This patch seems to have fallen through the cracks? Al?

There's been a v2 of this patch [*] and I'm about to send out a v3, so
please ignore this first version.

Thanks,
Andreas

[*] https://lore.kernel.org/linux-fsdevel/20191129142045.7215-1-agruenba@redhat.com/


      reply	other threads:[~2019-12-18 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 19:02 [PATCH] fs: Fix overflow in block_page_mkwrite Andreas Gruenbacher
2019-11-07  8:43 ` Christoph Hellwig
2019-12-18 12:43 ` Jan Kara
2019-12-18 12:51   ` Andreas Gruenbacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHc6FU4SodZg1XTZ-BRjTrYiWVdGz4ZfbzZQtevv=TCuHwxbJw@mail.gmail.com' \
    --to=agruenba@redhat.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).