* [PATCH] gfs2: Set .migrate_folio in gfs2_{rgrp,meta}_aops
@ 2025-07-14 16:54 Andrew Price
2025-07-15 11:13 ` Andreas Gruenbacher
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Price @ 2025-07-14 16:54 UTC (permalink / raw)
To: agruenba; +Cc: gfs2, willy, linux-fsdevel
Clears up the warning added in 7ee3647243e5 ("migrate: Remove call to
->writepage") that occurs in various xfstests, causing "something found
in dmesg" failures.
[ 341.136573] gfs2_meta_aops does not implement migrate_folio
[ 341.136953] WARNING: CPU: 1 PID: 36 at mm/migrate.c:944 move_to_new_folio+0x2f8/0x300
Signed-off-by: Andrew Price <anprice@redhat.com>
---
fs/gfs2/meta_io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index 9dc8885c95d07..66ee10929736f 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -103,6 +103,7 @@ const struct address_space_operations gfs2_meta_aops = {
.invalidate_folio = block_invalidate_folio,
.writepages = gfs2_aspace_writepages,
.release_folio = gfs2_release_folio,
+ .migrate_folio = buffer_migrate_folio_norefs,
};
const struct address_space_operations gfs2_rgrp_aops = {
@@ -110,6 +111,7 @@ const struct address_space_operations gfs2_rgrp_aops = {
.invalidate_folio = block_invalidate_folio,
.writepages = gfs2_aspace_writepages,
.release_folio = gfs2_release_folio,
+ .migrate_folio = buffer_migrate_folio_norefs,
};
/**
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gfs2: Set .migrate_folio in gfs2_{rgrp,meta}_aops
2025-07-14 16:54 [PATCH] gfs2: Set .migrate_folio in gfs2_{rgrp,meta}_aops Andrew Price
@ 2025-07-15 11:13 ` Andreas Gruenbacher
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Gruenbacher @ 2025-07-15 11:13 UTC (permalink / raw)
To: Andrew Price; +Cc: gfs2, willy, linux-fsdevel
On Mon, Jul 14, 2025 at 6:55 PM Andrew Price <anprice@redhat.com> wrote:
> Clears up the warning added in 7ee3647243e5 ("migrate: Remove call to
> ->writepage") that occurs in various xfstests, causing "something found
> in dmesg" failures.
>
> [ 341.136573] gfs2_meta_aops does not implement migrate_folio
> [ 341.136953] WARNING: CPU: 1 PID: 36 at mm/migrate.c:944 move_to_new_folio+0x2f8/0x300
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
> fs/gfs2/meta_io.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
> index 9dc8885c95d07..66ee10929736f 100644
> --- a/fs/gfs2/meta_io.c
> +++ b/fs/gfs2/meta_io.c
> @@ -103,6 +103,7 @@ const struct address_space_operations gfs2_meta_aops = {
> .invalidate_folio = block_invalidate_folio,
> .writepages = gfs2_aspace_writepages,
> .release_folio = gfs2_release_folio,
> + .migrate_folio = buffer_migrate_folio_norefs,
> };
>
> const struct address_space_operations gfs2_rgrp_aops = {
> @@ -110,6 +111,7 @@ const struct address_space_operations gfs2_rgrp_aops = {
> .invalidate_folio = block_invalidate_folio,
> .writepages = gfs2_aspace_writepages,
> .release_folio = gfs2_release_folio,
> + .migrate_folio = buffer_migrate_folio_norefs,
> };
>
> /**
Thanks, I've added this to for-next.
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-15 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 16:54 [PATCH] gfs2: Set .migrate_folio in gfs2_{rgrp,meta}_aops Andrew Price
2025-07-15 11:13 ` Andreas Gruenbacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).